-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added post validation steps for NS loadbalancing scenarios #4193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gw info logs too many times, if possible lets try to avoid duplication and remove it if its part of GW initialization
|
||
# Add listeners and namespaces to newly added GWs | ||
for subsys_args in config["subsystems"]: | ||
LOG.info(f"Adding listeners for {scaleup_nodes}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HaruChebrolu It is better to add all listeners first and then move to new namespace addition in interest of time and IO getting stuck . Though they are new GWs, it is always advised to add all listeners before adding namespaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The order below would be more beneficial for scale up new Gws
- Run IO on old namespaces
- ceph orch apply new GW nodes
- Add listeners on all subsystems for alll new GW nodes immediately
- Then add namespaces
- Disconnect, discover and connect again from initiators
Currently it is 2,1,4-3,5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update the loop to add listeners to all subsystems and then move to adding namespaces.
And currently I running IO on old namespaces and then I am applying new GW nodes, please let me know if I am missing something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @HaruChebrolu
I got confused with
cephci/tests/nvmeof/test_ceph_nvmeof_loadbalancing.py
Lines 280 to 283 in a16e3a8
ha.scale_up(scaleup_nodes, gw_nodes, old_namespaces) | |
# Validate IO for old namespaces | |
ha.validate_scaleup(scaleup_nodes, old_namespaces) |
i think you are validating IO for old namespaces after orch apply new nodes? If its case then its fine. thanks
Another suggestionis you can validate IO for old namespaces as well as new namespaces together after listener add and namespace add. We can do this way too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
I will try to mitigate as much as I can, but I am little skeptical if I can completely avoid it. |
Signed-off-by: Chebrolu <[email protected]>
a16e3a8
to
02a58cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: HaruChebrolu, Manohar-Murthy, rahullepakshi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Added post validation steps for NS loadbalancing scenarios.
Logs: http://magna002.ceph.redhat.com/cephci-jenkins/harika/ns_loadbalancing/cephci-run-NLZQ8M/