Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick-9177][Release 4.13] Replacing crypt device check from pod to node. #10040

Merged
merged 4 commits into from
Jul 10, 2024
Merged

[cherry-pick-9177][Release 4.13] Replacing crypt device check from pod to node. #10040

merged 4 commits into from
Jul 10, 2024

Conversation

paraggit
Copy link
Contributor

@paraggit paraggit commented Jul 3, 2024

Release 4.13 cherry pick pr 9177

@paraggit paraggit requested review from a team as code owners July 3, 2024 18:16
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 3, 2024

@paraggit: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Release 4.13 cherry pick pr 9177

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Jul 3, 2024
@paraggit paraggit changed the title Release 4.13 cherry pick pr 9177 [cherry-pick-9177][Release 4.13] Replacing crypt device check from pod to node. Jul 3, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 3, 2024

@paraggit: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[cherry-pick-9177][Release 4.13] Replacing crypt device check from pod to node.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ocs-ci
ocs-ci reviewed Jul 3, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/pv/pv_encryption/test_kmip_rbd_pv_encryption.py tests/functional/pv/pv_encryption/test_rbd_pv_encryption.py tests/functional/pv/pv_encryption/test_rbd_pv_encryption_vaulttenantsa.py tests/functional/ui/test_pv_encryption_ui.py
Additional Test Params:
OCP VERSION: 4.13
OCS VERSION: 4.13
tested against branch: release-4.13

Job FAILED (installation failed, tests not executed).

ocs-ci
ocs-ci reviewed Jul 4, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/pv_services/pv_encryption/test_kmip_rbd_pv_encryption.py tests/manage/pv_services/pv_encryption/test_rbd_pv_encryption.py tests/manage/pv_services/pv_encryption/test_rbd_pv_encryption_vaulttenantsa.py tests/ui/test_pv_encryption_ui.py
Additional Test Params:
OCP VERSION: 4.13
OCS VERSION: 4.13
tested against branch: release-4.13

Job PASSED.

ocs-ci
ocs-ci reviewed Jul 4, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/pv_services/pv_encryption/test_kmip_rbd_pv_encryption.py tests/manage/pv_services/pv_encryption/test_rbd_pv_encryption.py tests/manage/pv_services/pv_encryption/test_rbd_pv_encryption_vaulttenantsa.py tests/ui/test_pv_encryption_ui.py
Additional Test Params:
OCP VERSION: 4.13
OCS VERSION: 4.13
tested against branch: release-4.13

Job UNSTABLE (some or all tests failed).

@paraggit paraggit added Verified Mark when PR was verified and log provided cherry-pick This is cherry-pick (backport) labels Jul 4, 2024
ocs-ci
ocs-ci reviewed Jul 4, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/pv_services/pv_encryption/test_kmip_rbd_pv_encryption.py tests/manage/pv_services/pv_encryption/test_rbd_pv_encryption.py tests/manage/pv_services/pv_encryption/test_rbd_pv_encryption_vaulttenantsa.py tests/ui/test_pv_encryption_ui.py
Additional Test Params:
OCP VERSION: 4.13
OCS VERSION: 4.13
tested against branch: release-4.13

Job UNSTABLE (some or all tests failed).

ocs-ci
ocs-ci reviewed Jul 4, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/pv_services/pv_encryption/test_kmip_rbd_pv_encryption.py tests/manage/pv_services/pv_encryption/test_rbd_pv_encryption.py tests/manage/pv_services/pv_encryption/test_rbd_pv_encryption_vaulttenantsa.py tests/ui/test_pv_encryption_ui.py
Additional Test Params:
OCP VERSION: 4.13
OCS VERSION: 4.13
tested against branch: release-4.13

Job FAILED (installation failed, tests not executed).

ocs-ci
ocs-ci reviewed Jul 4, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/pv_services/pv_encryption/test_kmip_rbd_pv_encryption.py tests/manage/pv_services/pv_encryption/test_rbd_pv_encryption.py tests/manage/pv_services/pv_encryption/test_rbd_pv_encryption_vaulttenantsa.py tests/ui/test_pv_encryption_ui.py
Additional Test Params:
OCP VERSION: 4.13
OCS VERSION: 4.13
tested against branch: release-4.13

Job PASSED.

sidhant-agrawal
sidhant-agrawal previously approved these changes Jul 5, 2024
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Jul 5, 2024
@paraggit
Incorporated review Comments.
37b6cca 
Signed-off-by: Parag Kamble <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Jul 9, 2024
ocs-ci
ocs-ci reviewed Jul 9, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/pv_services/pv_encryption/test_kmip_rbd_pv_encryption.py tests/manage/pv_services/pv_encryption/test_rbd_pv_encryption.py tests/manage/pv_services/pv_encryption/test_rbd_pv_encryption_vaulttenantsa.py tests/ui/test_pv_encryption_ui.py
Additional Test Params:
OCP VERSION: 4.13
OCS VERSION: 4.13
tested against branch: release-4.13

Job FAILED (installation failed, tests not executed).

ocs-ci
ocs-ci reviewed Jul 9, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/pv_services/pv_encryption/test_kmip_rbd_pv_encryption.py tests/manage/pv_services/pv_encryption/test_rbd_pv_encryption.py tests/manage/pv_services/pv_encryption/test_rbd_pv_encryption_vaulttenantsa.py tests/ui/test_pv_encryption_ui.py
Additional Test Params:
OCP VERSION: 4.13
OCS VERSION: 4.13
tested against branch: release-4.13

Job PASSED.

@openshift-ci openshift-ci bot added the lgtm label Jul 10, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ebenahar, paraggit, sidhant-agrawal

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ebenahar ebenahar merged commit b4856cd into red-hat-storage:release-4.13 Jul 10, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@sidhant-agrawal sidhant-agrawal sidhant-agrawal approved these changes

@ebenahar ebenahar ebenahar approved these changes

Assignees

@ebenahar ebenahar

@sidhant-agrawal sidhant-agrawal

Labels
cherry-pick This is cherry-pick (backport) lgtm size/L PR that changes 100-499 lines Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paraggit @ebenahar @sidhant-agrawal @ocs-ci