Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick-9177][Release 4.12] Replacing crypt device check from pod to node. #10042

Conversation

paraggit
Copy link
Contributor

@paraggit paraggit commented Jul 4, 2024

[cherry-pick-9177][Release 4.12] Replacing crypt device check from pod to node.

@paraggit paraggit requested review from a team as code owners July 4, 2024 04:26
Copy link

openshift-ci bot commented Jul 4, 2024

@paraggit: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[cherry-pick-9177][Release 4.12] Replacing crypt device check from pod to node.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Jul 4, 2024
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/pv_services/pv_encryption/test_kmip_rbd_pv_encryption.py tests/manage/pv_services/pv_encryption/test_rbd_pv_encryption.py tests/manage/pv_services/pv_encryption/test_rbd_pv_encryption_vaulttenantsa.py tests/ui/test_pv_encryption_ui.py
Additional Test Params:
OCP VERSION: 4.12
OCS VERSION: 4.12
tested against branch: release-4.12

Job PASSED.

@paraggit paraggit added Verified Mark when PR was verified and log provided cherry-pick This is cherry-pick (backport) labels Jul 4, 2024
sidhant-agrawal
sidhant-agrawal previously approved these changes Jul 5, 2024
ocs_ci/ocs/node.py Outdated Show resolved Hide resolved
ocs_ci/ocs/node.py Outdated Show resolved Hide resolved
ocs_ci/ocs/node.py Show resolved Hide resolved
Signed-off-by: Parag Kamble <[email protected]>
Signed-off-by: Parag Kamble <[email protected]>
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/pv_services/pv_encryption/test_kmip_rbd_pv_encryption.py tests/manage/pv_services/pv_encryption/test_rbd_pv_encryption.py tests/manage/pv_services/pv_encryption/test_rbd_pv_encryption_vaulttenantsa.py tests/ui/test_pv_encryption_ui.py
Additional Test Params:
OCP VERSION: 4.12
OCS VERSION: 4.12
tested against branch: release-4.12

Job PASSED.

Copy link

openshift-ci bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ebenahar, paraggit, sidhant-agrawal

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ebenahar ebenahar merged commit 43ecb71 into red-hat-storage:release-4.12 Jul 10, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick This is cherry-pick (backport) lgtm size/L PR that changes 100-499 lines Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants