-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stretch cluster + CNV automation #10077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: mashetty-stj29
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_netsplit.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
Job UNSTABLE (some or all tests failed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: mashetty-stj29
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_netsplit.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
Job FAILED (installation failed, tests not executed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: mashetty-stj30
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_netsplit.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
Job UNSTABLE (some or all tests failed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: mashetty-stj30
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_netsplit.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
Job UNSTABLE (some or all tests failed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: mashetty-stj30
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_netsplit.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
Job UNSTABLE (some or all tests failed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: mashetty-stj30
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_netsplit.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
Job UNSTABLE (some or all tests failed).
ocs_ci/deployment/cnv.py
Outdated
cnv_namespace.delete(resource_name=constants.CNV_NAMESPACE) | ||
logger.info(f"Deleted the namespace {constants.CNV_NAMESPACE}") | ||
|
||
def cleanup_cnv(self, check_cnv_installed=False): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we rename it to uninstall_cnv
tests/conftest.py
Outdated
volumeimportsource_obj = get_volumeimportsource(pvc_obj=pvc_obj) | ||
vm_obj.delete() | ||
log.info(f"Successfully deleted VM {vm_obj.name}") | ||
pvc_obj.delete() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do not need to wait for the resource to delete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by default wait=True, so delete itself makes sure the resource is deleted. correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the wait here is for the delete command to complete. It will not wait for the resource to delete.
Please check https://github.com/mashetty330/ocs-ci/blob/cdc6601c397f41b37d0c2522de0a94035a2a8ae4/ocs_ci/ocs/ocp.py#L434
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def delete(self):
"""
Delete the VirtualMachine
"""
self.vm_ocp_obj.delete(resource_name=self._vm_name)
self.vm_ocp_obj.wait_for_delete(resource_name=self._vm_name, timeout=180)
tests/conftest.py
Outdated
|
||
|
||
@pytest.fixture() | ||
def setup_vms_standalone_pvc(request, project_factory, setup_cnv): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the need to pass the setup_cnv here?
tests/conftest.py
Outdated
vm_obj = None | ||
|
||
def factory(): | ||
nonlocal vm_obj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc string missing
cdc6601
to
6b1a390
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: mashetty-sts2
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_zone_shutdown_and_crash.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master
Job UNSTABLE (some or all tests failed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: mashetty-sts2
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_zone_shutdown_and_crash.py:: TestZoneShutdownsAndCrashes::test_zone_crashes
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master
Job FAILED (installation failed, tests not executed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: mashetty-sts2
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_zone_shutdown_and_crash.py:: TestZoneShutdownsAndCrashes::test_zone_crashes
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
Job FAILED (installation failed, tests not executed).
Signed-off-by: Mahesh Shetty <[email protected]>
Signed-off-by: Mahesh Shetty <[email protected]>
Signed-off-by: Mahesh Shetty <[email protected]>
Signed-off-by: Mahesh Shetty <[email protected]>
Signed-off-by: Mahesh Shetty <[email protected]>
Signed-off-by: Mahesh Shetty <[email protected]>
Signed-off-by: Mahesh Shetty <[email protected]>
Signed-off-by: Mahesh Shetty <[email protected]>
Signed-off-by: Mahesh Shetty <[email protected]>
Signed-off-by: Mahesh Shetty <[email protected]>
Signed-off-by: Mahesh Shetty <[email protected]>
Signed-off-by: Mahesh Shetty <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: mashetty-sts2
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_zone_shutdown_and_crash.py:: TestZoneShutdownsAndCrashes::test_zone_crashes
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
Job FAILED (installation failed, tests not executed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: mashetty-sts2
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_zone_shutdown_and_crash.py::TestZoneShutdownsAndCrashes::test_zone_crashes
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
Job UNSTABLE (some or all tests failed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: mashetty-sts2
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_zone_shutdown_and_crash.py::TestZoneShutdownsAndCrashes::test_zone_crashes
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: mashetty-sts2
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/disaster-recovery/sc_arbiter/test_zone_shutdown_and_crash.py::TestZoneShutdownsAndCrashes::test_zone_shutdowns
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Akarsha-rai, mashetty330, PrasadDesala The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.