Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes TypeError while creating default backing_store #10106

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Fixes TypeError while creating default backing_store #10106

merged 1 commit into from
Aug 5, 2024

Conversation

udaysk23
Copy link
Contributor

Fixes #10104

@udaysk23 udaysk23 added MCG Multi Cloud Gateway / NooBaa related issues Squad/Red labels Jul 15, 2024
@udaysk23 udaysk23 requested a review from a team as a code owner July 15, 2024 08:58
ocs-ci
ocs-ci reviewed Jul 15, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ukurundw-16
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/object/mcg/test_default_backingstore_override.py::TestDefaultBackingstoreOverride::test_default_buckets_backingstore
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

@udaysk23 udaysk23 requested review from keesturam, sagihirshfeld, mashetty330 and a team July 15, 2024 09:06
@udaysk23 udaysk23 added the Verified Mark when PR was verified and log provided label Jul 15, 2024
@openshift-ci openshift-ci bot added the lgtm label Jul 17, 2024
sagihirshfeld
sagihirshfeld approved these changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@sagihirshfeld sagihirshfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: keesturam, mashetty330, sagihirshfeld, udaysk23

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@keesturam keesturam merged commit 0ef387a into red-hat-storage:master Aug 5, 2024
6 of 7 checks passed
@petr-balogh
Copy link
Member

/cherry-pick release-4.16

@openshift-cherrypick-robot
Copy link
Collaborator

@petr-balogh: new pull request created: #10251

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@mashetty330 mashetty330 mashetty330 approved these changes

@sagihirshfeld sagihirshfeld sagihirshfeld approved these changes

@keesturam keesturam keesturam approved these changes

Assignees

@keesturam keesturam

@sagihirshfeld sagihirshfeld

@mashetty330 mashetty330

Labels
lgtm MCG Multi Cloud Gateway / NooBaa related issues size/XS Squad/Red Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hitting TypeError while creating "default_buckets_backingstore" due to incorrect comparision
7 participants
@udaysk23 @petr-balogh @openshift-cherrypick-robot @keesturam @sagihirshfeld @ocs-ci @mashetty330