Apply new pool workflow for 4.17 only #10183
Conversation
ebondare
added
Squad/Black
Signed-off-by: Elena Bondarenko <[email protected]>
ebondare
force-pushed
the
ui-pool-version-fix
branch
from
aa8932c to
628cd3a
Compare
|
Successful test run on 4.16: https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/40478/consoleFull |
| @@ -139,7 +140,8 @@ def test_blocking_pool_creation_rules(self, cephblockpool_factory_ui_class): | |||
| blocking_pool_tab.check_edit_labels(block_pool_obj.name) | |||
|
|
|||
| blocking_pool_tab.proceed_resource_creation() | |||
| blocking_pool_tab.do_click(blocking_pool_tab.bp_loc["pool_type_block"]) | |||
| if blocking_pool_tab.ocs_version_semantic >= version.VERSION_4_17: | |||
There was a problem hiding this comment.
can you please override method
proceed_resource_creation at the BlockPools class and insert this logic there?
It will look like
def proceed_resource_creation(self):
super().proceed_resource_creation()
if blocking_pool_tab.ocs_version_semantic >= version.VERSION_4_17:
self.do_click(self.bp_loc["pool_type_block"])
Signed-off-by: Elena Bondarenko <[email protected]>
pull-request-size
bot
added
size/S
|
New successful test run of test_blocking_pool_creation_rules: https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/40489/consoleFull |
|
The test run above was on 4.16 cluster, here is a successful test run on 4.17: https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/40528/console |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: DanielOsypenko, ebondare, fbalak The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.16 |
|
@ebondare: new pull request created: #10509 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
No description provided.