Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_bucket_logs_integrity - fix race condition by waiting for logs to appear before awaiting their removal #11086

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test_bucket_logs_integrity - fix race condition by waiting for logs to appear before awaiting their removal #11086

wants to merge 1 commit into from

Conversation

sagihirshfeld
Copy link
Contributor

Fixes: #11085

@sagihirshfeld sagihirshfeld added Needs Testing Run tests and provide logs link MCG Multi Cloud Gateway / NooBaa related issues Squad/Red labels Dec 30, 2024
@sagihirshfeld sagihirshfeld self-assigned this Dec 30, 2024
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Dec 30, 2024
@sagihirshfeld sagihirshfeld force-pushed the fix-await-interm-logs-transfer branch from cd72a8e to ef8343b Compare January 13, 2025 16:29
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines and removed size/S PR that changes 10-29 lines labels Jan 13, 2025
ocs-ci
ocs-ci reviewed Jan 13, 2025
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: shirshfe-418ibm19
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_bucket_logs.py::TestBucketLogs::test_bucket_logs_integrity
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci
ocs-ci reviewed Jan 13, 2025
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: shirshfe-418ibm19
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_bucket_logs.py::TestBucketLogs::test_bucket_logs_integrity
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job PASSED.

@sagihirshfeld sagihirshfeld added Verified Mark when PR was verified and log provided and removed Needs Testing Run tests and provide logs link labels Jan 14, 2025
@sagihirshfeld sagihirshfeld marked this pull request as ready for review January 14, 2025 08:02
@sagihirshfeld sagihirshfeld requested a review from a team as a code owner January 14, 2025 08:02
@openshift-ci openshift-ci bot added the lgtm label Jan 21, 2025
ypersky1980
ypersky1980 approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@ypersky1980 ypersky1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: keesturam, sagihirshfeld, ypersky1980

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@ypersky1980 ypersky1980 ypersky1980 approved these changes

@keesturam keesturam keesturam approved these changes

@udaysk23 udaysk23 Awaiting requested review from udaysk23

@mashetty330 mashetty330 Awaiting requested review from mashetty330

Assignees

@keesturam keesturam

@sagihirshfeld sagihirshfeld

@ypersky1980 ypersky1980

Labels
lgtm MCG Multi Cloud Gateway / NooBaa related issues size/M PR that changes 30-99 lines Squad/Red Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_bucket_logs_integrity often fails due to a race condition
4 participants
@sagihirshfeld @keesturam @ocs-ci @ypersky1980