VM snapshot pvc clone #11151

ayush-patni · 2025-01-15T07:55:44Z

This PR consists of two test cases resp for CNV: VM snapshot pvc clone.
Replacing PR 11062 with this one for better availability

openshift-ci · 2025-01-15T07:55:49Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ayush-patni

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ocs-ci

PR validation on existing cluster

Cluster Name: apatni-cnv-hotpl2
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/workloads/cnv/test_vm_snapshot_cloning_ops.py::TestVmSnapshotClone::test_vm_snapshot_pvc_clone
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci

PR validation on existing cluster

Cluster Name: apatni-cnv-hotpl2
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/workloads/cnv/test_vm_snapshot_cloning_ops.py::TestVmSnapshotClone::test_vm_snapshot_pvc_clone
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci

PR validation on existing cluster

Cluster Name: apatni-cnv-hotpl2
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/workloads/cnv/test_vm_snapshot_cloning_ops.py::TestVmSnapshotClone::test_vm_snapshot_pvc_clone
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci

PR validation on existing cluster

Cluster Name: apatni-cnv-snap
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/workloads/cnv/test_vm_snapshot_cloning_ops.py::TestVmSnapshotClone::test_vm_snapshot_pvc_clone
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job PASSED.

PrasadDesala · 2025-01-21T06:43:26Z

tests/functional/workloads/cnv/test_vm_snapshot_cloning_ops.py

+        7. Verify that the data persisted after cloning
+        """
+        proj_obj = project_factory()
+        file_paths = ["/file.txt", "/new_file.txt"]


You are not writing new data in the test. There is no need for new_file.txt here

We'll be utilising the path for new data
https://github.com/red-hat-storage/ocs-ci/pull/11151/files#r1923153342

PrasadDesala · 2025-01-21T06:43:56Z

tests/functional/workloads/cnv/test_vm_snapshot_cloning_ops.py

+                existing_pvc_obj=res_snap_obj,
+                namespace=vm_obj.namespace,
+                storageclass=vm_obj.sc_name,
+            )[-1]


indexing was removed in the cnv_workload fixture, please rebase your PR to pull the latest code

PrasadDesala · 2025-01-21T06:44:08Z

tests/functional/workloads/cnv/test_vm_snapshot_cloning_ops.py

+            # Clone the restored VM
+            res_vm_obj_clone = clone_vm_workload(
+                res_vm_obj, namespace=vm_obj.namespace
+            )[-1]


indexing was removed in the clone_vm_workload fixture, please rebase your PR to pull the latest code

PrasadDesala · 2025-01-21T06:44:34Z

tests/functional/workloads/cnv/test_vm_snapshot_cloning_ops.py

@@ -119,3 +119,76 @@ def test_vm_snapshot_ops(
            source_csum == res_csum
        ), f"Failed: MD5 comparison between source {vm_obj.name} and cloned {res_vm_obj.name} VMs"
        res_vm_obj.stop()
+
+    @workloads
+    @pytest.mark.polarion_id("OCS-")


Please create a testcase in polarion and add its id here

avd-sagare · 2025-01-21T06:47:40Z

tests/functional/workloads/cnv/test_vm_snapshot_cloning_ops.py

+            assert source_csum == res_csum, (
+                f"Failed: MD5 comparison between source {vm_obj.name} and cloned "
+                f"{res_vm_obj.name} VMs"
+            )


Add new data in cloned vm

avd-sagare · 2025-01-21T06:48:14Z

tests/functional/workloads/cnv/test_vm_snapshot_cloning_ops.py

+        4. Deploy a new VM using the restored snapshot PVC
+        5. Clone the VM workload to create a new PVC from the restored snapshot PVC
+        6. Check data integrity in the cloned VM
+        7. Verify that the data persisted after cloning


Add step which we added at last

avd-sagare · 2025-01-21T06:50:42Z

tests/functional/workloads/cnv/test_vm_snapshot_cloning_ops.py

+                size=vm_obj.pvc_size,
+                volume_mode=snap_obj.parent_volume_mode,
+                access_mode=vm_obj.pvc_access_mode,
+                status=constants.STATUS_BOUND,


By default is constants.STATUS_BOUND

ocs-ci

PR validation on existing cluster

Cluster Name: apatni-cnv-snap3
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/workloads/cnv/test_vm_snapshot_cloning_ops.py::TestVmSnapshotClone::test_vm_snapshot_pvc_clone
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci

PR validation on existing cluster

Cluster Name: apatni-cnv-snap3
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/workloads/cnv/test_vm_snapshot_cloning_ops.py::TestVmSnapshotClone::test_vm_snapshot_pvc_clone
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job UNSTABLE (some or all tests failed).

Signed-off-by: AYUSH-D-PATNI <[email protected]>

ocs-ci

PR validation on existing cluster

Cluster Name: apatni-cnv-snap3
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/workloads/cnv/test_vm_snapshot_cloning_ops.py::TestVmSnapshotClone::test_vm_snapshot_pvc_clone
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci

PR validation on existing cluster

Cluster Name: apatni-cnv-snap3
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/workloads/cnv/test_vm_snapshot_cloning_ops.py::TestVmSnapshotClone::test_vm_snapshot_pvc_clone
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job PASSED.

ayush-patni requested review from parikshithb, avd-sagare and hnallurv January 15, 2025 07:55

ayush-patni requested a review from a team as a code owner January 15, 2025 07:55

pull-request-size bot added the size/M PR that changes 30-99 lines label Jan 15, 2025

pull-request-size bot added size/L PR that changes 100-499 lines size/M PR that changes 30-99 lines and removed size/M PR that changes 30-99 lines size/L PR that changes 100-499 lines labels Jan 15, 2025

ocs-ci reviewed Jan 15, 2025

View reviewed changes

ocs-ci reviewed Jan 16, 2025

View reviewed changes

ayush-patni added the team/e2e E2E team related issues/PRs label Jan 17, 2025

PrasadDesala reviewed Jan 21, 2025

View reviewed changes

avd-sagare reviewed Jan 21, 2025

View reviewed changes

ayush-patni force-pushed the vm-snap-pvc-clone branch from d1893f3 to 1bbf69d Compare January 21, 2025 10:39

ocs-ci reviewed Jan 23, 2025

View reviewed changes

AYUSH-D-PATNI and others added 8 commits January 23, 2025 15:18

added two tests

b7c85d2

Signed-off-by: AYUSH-D-PATNI <[email protected]>

improvised test case as per cmts

472ca99

Signed-off-by: AYUSH-D-PATNI <[email protected]>

logg

b3bb4b8

Signed-off-by: AYUSH-D-PATNI <[email protected]>

added pvc_clone_factory fixture and better logs

815add1

Signed-off-by: AYUSH-D-PATNI <[email protected]>

added test steps to test_vm_pvc_expansion.py

99d1255

Signed-off-by: AYUSH-D-PATNI <[email protected]>

added test steps into test_vm_snapshot_clone.py

387e752

Signed-off-by: AYUSH-D-PATNI <[email protected]>

added comments in vm_pvc_expansion

a98ffdf

Signed-off-by: AYUSH-D-PATNI <[email protected]>

update as per pr review

62cbc37

Signed-off-by: AYUSH-D-PATNI <[email protected]>

AYUSH-D-PATNI added 8 commits January 23, 2025 15:18

updated test case

7771844

Signed-off-by: AYUSH-D-PATNI <[email protected]>

added test_vm_snapshot_pvc_clone

d5936bb

Signed-off-by: AYUSH-D-PATNI <[email protected]>

test_vm_snapshot_pvc_clone

dec5685

Signed-off-by: AYUSH-D-PATNI <[email protected]>

removed seperate file for tc

2eb359e

Signed-off-by: AYUSH-D-PATNI <[email protected]>

updated test_vm_snap_pvc_clone with new approach

d5ed67a

Signed-off-by: AYUSH-D-PATNI <[email protected]>

updated test_vm_snapshot_cloning_ops.py with tc and steps

474056e

Signed-off-by: AYUSH-D-PATNI <[email protected]>

update as per review cmts

fa238a2

Signed-off-by: AYUSH-D-PATNI <[email protected]>

updated guest memory in vm yaml

8fa4474

Signed-off-by: AYUSH-D-PATNI <[email protected]>

ayush-patni force-pushed the vm-snap-pvc-clone branch from 6b155db to 8fa4474 Compare January 23, 2025 09:51

ayush-patni requested a review from a team as a code owner January 23, 2025 09:51

ocs-ci reviewed Jan 23, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VM snapshot pvc clone #11151

VM snapshot pvc clone #11151

ayush-patni commented Jan 15, 2025

openshift-ci bot commented Jan 15, 2025

ocs-ci left a comment

ocs-ci left a comment

ocs-ci left a comment

ocs-ci left a comment

PrasadDesala Jan 21, 2025

ayush-patni Jan 21, 2025

PrasadDesala Jan 21, 2025

ayush-patni Jan 21, 2025

PrasadDesala Jan 21, 2025

ayush-patni Jan 21, 2025

PrasadDesala Jan 21, 2025

ayush-patni Jan 21, 2025

avd-sagare Jan 21, 2025

ayush-patni Jan 21, 2025

avd-sagare Jan 21, 2025

ayush-patni Jan 21, 2025

avd-sagare Jan 21, 2025

ayush-patni Jan 21, 2025

ocs-ci left a comment

ocs-ci left a comment

ocs-ci left a comment

ocs-ci left a comment

VM snapshot pvc clone #11151

Are you sure you want to change the base?

VM snapshot pvc clone #11151

Conversation

ayush-patni commented Jan 15, 2025

openshift-ci bot commented Jan 15, 2025

ocs-ci left a comment

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment