[4.18] MCG Bucket Notifications - add advanced tests, improvements and fixes #11260
+461
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following tests to test_bucket_notifications.py:
1.
test_multi_notif_event_types
: check that other operations besides PutObject result in the expected notificaitons2.
test_multiple_bucket_notifs_setups
: verify that MCG can handle bucket notifications configurations, where different buckets are each sending notifications to a separate Kafka topic.3.
test_bucket_notifs_shared_topic
: test that multiple buckets can send their notifications to the same Kafka topicAdditionally, the following fixes were made:
delete_object_tags
test_bucket_notifications.py
test_bucket_notifications[default-logs-pvc]
andtest_bucket_notifications[provided-logs-pvc]
And finally, the following improvements/additions have been made:
BucketNotificationsManager::add_notif_conn_to_noobaa_cr
has been replaced by a simpler one from a static method from the MCG class.BucketNotificationsManager::add_notif_conn_to_noobaa_cr
andBucketNotificationsManager::put_bucket_notification
have been added.test_bucket_notifications
to show what events are missing from the notifications.add_env_vars_to_noobaa_core
fixture have been added toconftest.py