Delete leftover dns records when destroying ibmcloud clusters

[clacroix12]

Issue: https://url.corp.redhat.com/db47959

[ocs-ci]

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: deployment
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job FAILED (installation failed, tests not executed).

[dahorak]

Just one small suggestion, otherwise LGTM.

[ocs-ci]

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: deployment
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job PASSED.

[clacroix12]

Verified and confirmed the leftover record was deleted here: https://jenkins-csb-odf-qe-ocs4.dno.corp.redhat.com/job/qe-destroy-ocs-cluster/52685/consoleFull

The only issue was incorrectly referencing the wrong list in the log statement showing which IDs were found for deletion. I've pushed a fix addressing that.

[clacroix12]

I should also mention that this shouldn't be merged prior to the MR adding the config details to our credentials.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: clacroix12, dahorak, petr-balogh, vavuthu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[clacroix12]

/cherry-pick 4.17

[openshift-cherrypick-robot]

@clacroix12: cannot checkout 4.17: error checking out "4.17": exit status 1 error: pathspec '4.17' did not match any file(s) known to git

In response to this:

/cherry-pick 4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[clacroix12]

/cherry-pick release-4.17

[openshift-cherrypick-robot]

@clacroix12: new pull request created: #11313

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[clacroix12]

/cherry-pick release-4.16

[openshift-cherrypick-robot]

@clacroix12: #11300 failed to apply on top of branch "release-4.16":

Applying: Delete leftover dns records when destroying ibmcloud clusters
Using index info to reconstruct a base tree...
M	ocs_ci/deployment/ibmcloud.py
M	ocs_ci/ocs/constants.py
M	ocs_ci/utility/ibmcloud.py
Falling back to patching base and 3-way merge...
Auto-merging ocs_ci/utility/ibmcloud.py
CONFLICT (content): Merge conflict in ocs_ci/utility/ibmcloud.py
Auto-merging ocs_ci/ocs/constants.py
Auto-merging ocs_ci/deployment/ibmcloud.py
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Delete leftover dns records when destroying ibmcloud clusters

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[clacroix12]

Manually cherry-picked for other release branches here:

#11314
#11315
#11316