Ignore rook-ceph-osd-key-rotation leftovers #11324
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagihirshfeld
requested review from
keesturam,
udaysk23,
ypersky1980,
keemano and
mashetty330
sagihirshfeld
force-pushed
the
ignore-rook-ceph-osd-key-rotation-leftovers
branch
from
e71fdf8 to
e4a058e
Compare
pull-request-size
bot
added
size/S
paraggit
previously approved these changes
Feb 10, 2025
Signed-off-by: Sagi Hirshfeld <[email protected]>
sagihirshfeld
force-pushed
the
ignore-rook-ceph-osd-key-rotation-leftovers
branch
from
e4a058e to
ab43a14
Compare
sagihirshfeld
added
Squad/Red
Verified
keesturam
approved these changes
Feb 11, 2025
paraggit
approved these changes
Feb 11, 2025
petr-balogh
approved these changes
Feb 11, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: keesturam, paraggit, petr-balogh, sagihirshfeld The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Is this 4.18 specific or do we need cherry-pick to older release branches @sagihirshfeld ? |
|
@petr-balogh This is specific to 4.18 so cherry-picking is not necessary. After taking a closer look at the root problem, I'm pretty sure this leftover started showing only in 4.18 after this test was added: #11001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11323
Note that I've used @petr-balogh's approach from #11198