Adding kms policy name for same kms encryption keys

[shivamdurgbuns]

Fixes issue: #11495

[shivamdurgbuns]

Verification job: https://jenkins-csb-odf-qe-ocs4.dno.corp.redhat.com/job/qe-rdr-setup/1655/
getting same policy name and token value for both the clusters

[shivamdurgbuns]

Verification job here: https://jenkins-csb-odf-qe-ocs4.dno.corp.redhat.com/job/qe-rdr-setup/1667/

[petr-balogh]

New validation:
https://url.corp.redhat.com/3d8fd58

[petr-balogh]

Suggested change

	self.vault_policy_name = self.kms_vault_policy_name()
	self.vault_policy_name = self.kms_vault_policy_name

There is an issue:

2025-03-05 12:12:01  >       self.vault_policy_name = self.kms_vault_policy_name()
2025-03-05 12:12:01  E       TypeError: 'str' object is not callable

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shivamdurgbuns

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[shivamdurgbuns]

new vaildation job: https://jenkins-csb-odf-qe-ocs4.dno.corp.redhat.com/job/qe-rdr-setup/1680/

[petr-balogh]

typo in poilcy_data
and you are repeating this unnecesarly. Should be defined once only.
This is simplified how you can do this:

Suggested change

	json_out = json.loads(out)
	if self.vault_policy_name in json_out:
	# if policy already exists append the secondary cluster backend path to the policy
	poilcy_data = (
	f"\n}}\n"
	f'path "{self.vault_backend_path}/*" {{\n'
	f' capabilities = ["create", "read", "update","delete"]'
	)
	existing_policy_data = None
	read_policy_cmd = f"vault policy read {self.vault_policy_name}"
	try:
	existing_policy_data = subprocess.check_output(shlex.split(read_policy_cmd))
	logger.info(f"Existing policy found!:\n{existing_policy_data}")
	expect Exception:
	logger.info("No existing policy found!")
	policy_backend_path = (
	f'path "{self.vault_backend_path}/*" {{\n'
	f' capabilities = ["create", "read", "update","delete"]'
	f"\n}}\n"
	)
	policy_sys_mount = (
	f'path "sys/mounts" {{\n'
	f'capabilities = ["read"]\n'
	f"}}"
	)
	if existing_policy_data is None:
	policy = policy_backend_path + policy_sys_mount
	else:
	policy = policy_backend_path + existing_policy_data
	vault_hcl = tempfile.NamedTemporaryFile(
	mode="a+", prefix="test", delete=False
	)
	logger.info(
	f"Creating or updating policy: {self.vault_policy_name} with content:\n"
	f"{policy}"
	)
	with open(vault_hcl.name, "a") as hcl:
	hcl.write(policy)

[petr-balogh]

and the rest from this line can be deleted if you will follow the suggestion from code above