Test overriding the noobaa-default backingstore + add support for RGW backingstore creation #8193

sagihirshfeld · 2023-08-06T15:01:59Z

Coverage for https://url.corp.redhat.com/140509f

The implementation of the upgrade TC required to override the default backingstore with a backingstore of the same type, in order to limit the affect on other tests. To handle the cases where the default backingstore is using RGW (like in our vSphere deployments) support for RGW backingstore creation has been added, and two basic test cases has been added to validate this support while extending our coverage:

tests/manage/mcg/test_write_to_bucket.py::TestBucketIO::test_write_file_to_bucket[RGW-OC-1]
tests/manage/mcg/test_write_to_bucket.py::TestBucketIO::test_write_file_to_bucket[RGW-CLI-1]

Requires a backport to release-4.14

keesturam

neat PR!
LGTM.

ocs-ci

PR validation on existing cluster

Cluster Name: shirshfe-415vs01
Cluster Configuration:
PR Test Suite: tier1 or tier2
PR Test Path: tests/manage/mcg/test_default_backingstore_override.py
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci

PR validation on existing cluster

Cluster Name: shirshfe-415aws01
Cluster Configuration: conf/deployment/aws/ipi_3az_rhcos_3m_3w_3i.yaml
PR Test Suite:
PR Test Path: ;;tests/manage/mcg/test_default_backingstore_override.py::TestDefaultBackingstoreOverride::test_default_buckets_backingstore tests/manage/mcg/test_default_backingstore_override.py::TestDefaultBackingstoreOverride::test_bucketclass_replication_after_default_backingstore_override
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master

Job FAILED (installation failed, tests not executed).

Signed-off-by: Sagi Hirshfeld <[email protected]>

tests/functional/object/mcg/test_default_backingstore_override.py

ocs-ci

Unknown PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_default_backingstore_override.py::TestDefaultBackingstoreOverride::test_bucketclass_replication_after_default_backingstore_override
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master

Job state: ABORTED.

ocs-ci

PR validation on existing cluster

Cluster Name: shirshfe-415vs03
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/manage/mcg/test_default_backingstore_override.py::TestDefaultBackingstoreOverride::test_default_buckets_backingstore tests/manage/mcg/test_default_backingstore_override.py::TestDefaultBackingstoreOverride::test_bucketclass_replication_after_default_backingstore_override
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master

Job FAILED (installation failed, tests not executed).

ocs-ci

PR validation on existing cluster

Cluster Name: shirshfe-415vs03
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_default_backingstore_override.py::TestDefaultBackingstoreOverride::test_bucketclass_replication_after_default_backingstore_override
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci

PR validation on existing cluster

Cluster Name: shirshfe-415vs03
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_default_backingstore_override.py::TestDefaultBackingstoreOverride::test_bucketclass_replication_after_default_backingstore_override
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master

Job UNSTABLE (some or all tests failed).

Signed-off-by: Sagi Hirshfeld <[email protected]>

mashetty330

LGTM, this may need validation of both MCG tier1, tier2 tests. please run it.

ocs-ci

PR validation on existing cluster

Cluster Name: shirshfe-415i01
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_default_backingstore_override.py::TestDefaultBackingstoreOverride::test_bucketclass_replication_after_default_backingstore_override
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master

Job UNSTABLE (some or all tests failed).

Signed-off-by: Sagi Hirshfeld <[email protected]>

ocs-ci

PR validation on existing cluster

Cluster Name: shirshfe-415i01
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_default_backingstore_override.py::TestDefaultBackingstoreOverride::test_bucketclass_replication_after_default_backingstore_override
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master

Job PASSED.

udaysk23

LGTM

openshift-ci · 2024-02-08T05:50:07Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: keesturam, mashetty330, sagihirshfeld, udaysk23

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sagihirshfeld self-assigned this Aug 6, 2023

pull-request-size bot added the size/L PR that changes 100-499 lines label Aug 6, 2023

sagihirshfeld force-pushed the test-default-backingstore-override branch from 39b5748 to 27abb0b Compare August 6, 2023 15:03

sagihirshfeld added MCG Multi Cloud Gateway / NooBaa related issues MCG-4.14 Squad/Red labels Aug 8, 2023

sagihirshfeld force-pushed the test-default-backingstore-override branch 2 times, most recently from 8f72ab5 to fed5b70 Compare September 3, 2023 17:06

sagihirshfeld force-pushed the test-default-backingstore-override branch from fed5b70 to 5226821 Compare September 26, 2023 15:19

sagihirshfeld added the Needs Testing Run tests and provide logs link label Oct 1, 2023

keesturam previously approved these changes Oct 12, 2023

View reviewed changes

openshift-ci bot assigned keesturam Oct 12, 2023

openshift-ci bot added the lgtm label Oct 12, 2023

openshift-merge-robot added the needs-rebase label Nov 10, 2023

sagihirshfeld dismissed keesturam’s stale review via af9ff7e November 20, 2023 08:31

sagihirshfeld force-pushed the test-default-backingstore-override branch from 6d77f7c to af9ff7e Compare November 20, 2023 08:31

openshift-ci bot removed the lgtm label Nov 20, 2023

openshift-merge-robot removed the needs-rebase label Nov 20, 2023

pull-request-size bot added size/XL and removed size/L PR that changes 100-499 lines labels Nov 26, 2023

sagihirshfeld changed the title ~~Test overriding the noobaa-default backingstore~~ Test overriding the noobaa-default backingstore + add support for RGW backingstore creation Nov 26, 2023

openshift-ci bot added the do-not-merge/work-in-progress label Nov 26, 2023

sagihirshfeld force-pushed the test-default-backingstore-override branch from bb66eb9 to 30430bb Compare December 10, 2023 12:58

sagihirshfeld marked this pull request as ready for review December 10, 2023 12:58

sagihirshfeld requested review from a team as code owners December 10, 2023 12:58

openshift-ci bot removed the do-not-merge/work-in-progress label Dec 10, 2023

sagihirshfeld added the backport-required Mark for PRs that need to be backported to older release branches label Dec 17, 2023

ocs-ci reviewed Dec 17, 2023

View reviewed changes

ocs-ci reviewed Dec 18, 2023

View reviewed changes

sagihirshfeld added 3 commits January 18, 2024 11:24

Refactor + Add repli TC

05fd779

Signed-off-by: Sagi Hirshfeld <[email protected]>

Documentation and fixes to TC number 3

074c93d

Signed-off-by: Sagi Hirshfeld <[email protected]>

Add the @mcg decorator

64169be

Signed-off-by: Sagi Hirshfeld <[email protected]>

sagihirshfeld force-pushed the test-default-backingstore-override branch from 4e60518 to 64169be Compare January 18, 2024 09:25

udaysk23 reviewed Jan 18, 2024

View reviewed changes

tests/functional/object/mcg/test_default_backingstore_override.py Outdated Show resolved Hide resolved

sagihirshfeld added Needs Testing Run tests and provide logs link and removed Verified Mark when PR was verified and log provided labels Jan 18, 2024

ocs-ci reviewed Jan 18, 2024

View reviewed changes

sagihirshfeld force-pushed the test-default-backingstore-override branch from 17c912c to 8e21649 Compare January 21, 2024 13:39

ocs-ci reviewed Jan 21, 2024

View reviewed changes

sagihirshfeld force-pushed the test-default-backingstore-override branch 3 times, most recently from 9bb7023 to 02fd4e1 Compare January 21, 2024 16:43

Review fix + clear nb default bc cleanup on teardown

7318575

Signed-off-by: Sagi Hirshfeld <[email protected]>

sagihirshfeld force-pushed the test-default-backingstore-override branch from 02fd4e1 to 7318575 Compare January 21, 2024 17:29

mashetty330 reviewed Jan 24, 2024

View reviewed changes

ocs-ci reviewed Feb 5, 2024

View reviewed changes

Handle IBMCOS default backingtore case

ea913e5

Signed-off-by: Sagi Hirshfeld <[email protected]>

ocs-ci reviewed Feb 7, 2024

View reviewed changes

mashetty330 approved these changes Feb 7, 2024

View reviewed changes

openshift-ci bot assigned mashetty330 Feb 7, 2024

openshift-ci bot added the lgtm label Feb 7, 2024

udaysk23 approved these changes Feb 8, 2024

View reviewed changes

openshift-ci bot assigned udaysk23 Feb 8, 2024

keesturam approved these changes Feb 8, 2024

View reviewed changes

keesturam merged commit 42b5641 into red-hat-storage:master Feb 8, 2024
6 of 7 checks passed

sagihirshfeld removed the Needs Testing Run tests and provide logs link label Mar 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test overriding the noobaa-default backingstore + add support for RGW backingstore creation #8193

Test overriding the noobaa-default backingstore + add support for RGW backingstore creation #8193

sagihirshfeld commented Aug 6, 2023 •

edited

Loading

keesturam left a comment

ocs-ci left a comment

ocs-ci left a comment

ocs-ci left a comment

ocs-ci left a comment

ocs-ci left a comment

ocs-ci left a comment

mashetty330 left a comment •

edited

Loading

ocs-ci left a comment

ocs-ci left a comment

udaysk23 left a comment

openshift-ci bot commented Feb 8, 2024

Test overriding the noobaa-default backingstore + add support for RGW backingstore creation #8193

Test overriding the noobaa-default backingstore + add support for RGW backingstore creation #8193

Conversation

sagihirshfeld commented Aug 6, 2023 • edited Loading

keesturam left a comment

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

mashetty330 left a comment • edited Loading

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

udaysk23 left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Feb 8, 2024

sagihirshfeld commented Aug 6, 2023 •

edited

Loading

mashetty330 left a comment •

edited

Loading