Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ceph crashes after upgrade #8855

Merged
merged 1 commit into from
Nov 19, 2023
Merged

remove ceph crashes after upgrade #8855

merged 1 commit into from
Nov 19, 2023

Conversation

petr-balogh
Copy link
Member

@petr-balogh petr-balogh added team/ecosystem Ecosystem team related issues/PRs workaround labels Nov 15, 2023
@petr-balogh petr-balogh self-assigned this Nov 15, 2023
@petr-balogh petr-balogh requested a review from a team as a code owner November 15, 2023 16:50
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 15, 2023

@petr-balogh: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

remove ceph crashes after upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Nov 15, 2023
@petr-balogh petr-balogh mentioned this pull request Nov 15, 2023
Closed
@petr-balogh
Copy link
Member Author

Verification job triggered here:
https://url.corp.redhat.com/ee41b3a

vavuthu
vavuthu previously approved these changes Nov 16, 2023
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Nov 16, 2023
@petr-balogh petr-balogh force-pushed the cherry-pick-remove-ceph-crash-pr-8411 branch from 7339801 to 622e4ef Compare November 16, 2023 08:05
@openshift-ci openshift-ci bot removed the lgtm label Nov 16, 2023
@petr-balogh
Copy link
Member Author

petr-balogh commented Nov 16, 2023 •
edited
Loading

New verification triggered here:
https://url.corp.redhat.com/d076886

vavuthu
vavuthu previously approved these changes Nov 16, 2023
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Nov 16, 2023
@petr-balogh petr-balogh force-pushed the cherry-pick-remove-ceph-crash-pr-8411 branch from 622e4ef to 18a1b94 Compare November 16, 2023 14:43
@openshift-ci openshift-ci bot removed the lgtm label Nov 16, 2023
@petr-balogh
Copy link
Member Author

New verification:
https://url.corp.redhat.com/1c86b2f

shivamdurgbuns
shivamdurgbuns previously approved these changes Nov 16, 2023
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Nov 16, 2023
@petr-balogh petr-balogh force-pushed the cherry-pick-remove-ceph-crash-pr-8411 branch from 18a1b94 to a41a822 Compare November 16, 2023 16:49
@openshift-ci openshift-ci bot removed the lgtm label Nov 16, 2023
clacroix12
clacroix12 previously approved these changes Nov 16, 2023
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Nov 16, 2023
@petr-balogh petr-balogh dismissed stale reviews from shylesh and clacroix12 via adc570f November 16, 2023 18:39
@petr-balogh petr-balogh force-pushed the cherry-pick-remove-ceph-crash-pr-8411 branch from a41a822 to adc570f Compare November 16, 2023 18:39
@openshift-ci openshift-ci bot removed the lgtm label Nov 16, 2023
@petr-balogh
Copy link
Member Author

petr-balogh commented Nov 16, 2023 •
edited
Loading

New verification:
https://url.corp.redhat.com/c75f22a

shylesh
shylesh previously approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@shylesh shylesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Nov 16, 2023
dahorak
dahorak previously approved these changes Nov 16, 2023
View reviewed changes
@petr-balogh petr-balogh dismissed stale reviews from dahorak and shylesh via 5ab5714 November 16, 2023 23:28
@petr-balogh petr-balogh force-pushed the cherry-pick-remove-ceph-crash-pr-8411 branch from adc570f to 5ab5714 Compare November 16, 2023 23:28
@openshift-ci openshift-ci bot removed the lgtm label Nov 16, 2023
@petr-balogh petr-balogh force-pushed the cherry-pick-remove-ceph-crash-pr-8411 branch from 5ab5714 to 6f3ccec Compare November 16, 2023 23:36
shylesh
shylesh previously approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@shylesh shylesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Nov 16, 2023
vavuthu
vavuthu previously approved these changes Nov 17, 2023
View reviewed changes
@petr-balogh petr-balogh dismissed stale reviews from vavuthu and shylesh via 0899c2f November 17, 2023 15:33
@petr-balogh petr-balogh force-pushed the cherry-pick-remove-ceph-crash-pr-8411 branch from 6f3ccec to 0899c2f Compare November 17, 2023 15:33
@openshift-ci openshift-ci bot removed the lgtm label Nov 17, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 17, 2023

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: petr-balogh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

2 similar comments
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: petr-balogh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: petr-balogh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@petr-balogh
Copy link
Member Author

New verification:
https://url.corp.redhat.com/d7f6243

@petr-balogh
Copy link
Member Author

as from last approval there was just doc indention issue fixed, I will merge as is now to be able to run upgrade pipelines for new build with this W/A.

Issue to revert this is already opened here:
#8856

@petr-balogh petr-balogh merged commit 45ce4af into red-hat-storage:release-4.13 Nov 19, 2023
4 checks passed
@petr-balogh petr-balogh added the Verified Mark when PR was verified and log provided label Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OdedViner OdedViner OdedViner left review comments

@shivamdurgbuns shivamdurgbuns shivamdurgbuns left review comments

@vavuthu vavuthu vavuthu left review comments

@dahorak dahorak dahorak left review comments

@clacroix12 clacroix12 clacroix12 left review comments

@shylesh shylesh shylesh left review comments

Assignees

@shylesh shylesh

@clacroix12 clacroix12

@dahorak dahorak

@petr-balogh petr-balogh

@vavuthu vavuthu

@shivamdurgbuns shivamdurgbuns

@OdedViner OdedViner

Labels
size/M PR that changes 30-99 lines team/ecosystem Ecosystem team related issues/PRs Verified Mark when PR was verified and log provided workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@petr-balogh @shylesh @clacroix12 @dahorak @vavuthu @shivamdurgbuns @OdedViner