Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applied MS TC to hci PC platform using hci_pc_platform_required marker #8874

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Applied MS TC to hci PC platform using hci_pc_platform_required marker #8874

merged 3 commits into from
Nov 20, 2023

Conversation

suchita-g
Copy link
Contributor

Applied MS TC with managed_service_required to HCI Provider-Client platform using hci_pc_platform_required marker

@suchita-g suchita-g added the provider-client Provider-client solution label Nov 17, 2023
@suchita-g suchita-g self-assigned this Nov 17, 2023
@suchita-g suchita-g requested review from a team as code owners November 17, 2023 11:33
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Nov 17, 2023
@suchita-g
Applied MS TC to hci PC platform using hci_pc_platform_required marker
4abec61 
Signed-off-by: suchita-g <[email protected]>

Applied MS TC with managed_service_required to HCI Provider-Client platform
using hci_pc_platform_required marker

Signed-off-by: suchita-g <[email protected]>
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines and removed size/S PR that changes 10-29 lines labels Nov 17, 2023
ebenahar
ebenahar reviewed Nov 19, 2023
View reviewed changes
ocs_ci/framework/pytest_customization/marks.py Outdated
@@ -250,6 +250,27 @@
reason="Test runs ONLY on OSD or ROSA cluster",
)

multicluster_platform_required = pytest.mark.skipif(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't multicluster_platform_required imply also DR setup?
How about we rename these 2 marks to:

provider_client_platform_required
provider_client_ms_platform_required

@suchita-g suchita-g requested a review from ebenahar November 19, 2023 12:43
@openshift-ci openshift-ci bot added the lgtm label Nov 19, 2023
@suchita-g
Copy link
Contributor Author

Verified: https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-odf-multicluster/2085/

provider_client_ms_platform_required and pc_or_ms_provider_required , works as expected. However test may failed further during execution

@suchita-g suchita-g added the Verified Mark when PR was verified and log provided label Nov 20, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 20, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DanielOsypenko, ebenahar, ebondare, suchita-g

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ebenahar ebenahar merged commit 2ff80a2 into red-hat-storage:master Nov 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielOsypenko DanielOsypenko DanielOsypenko approved these changes

@ebondare ebondare ebondare approved these changes

@ebenahar ebenahar ebenahar approved these changes

@dahorak dahorak Awaiting requested review from dahorak

@yitzhak12 yitzhak12 Awaiting requested review from yitzhak12

@fbalak fbalak Awaiting requested review from fbalak

Assignees

@ebenahar ebenahar

@ebondare ebondare

@suchita-g suchita-g

@DanielOsypenko DanielOsypenko

Labels
lgtm provider-client Provider-client solution size/M PR that changes 30-99 lines Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suchita-g @ebenahar @ebondare @DanielOsypenko