Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mdr+cnv appset pull app and other fixes #9935

Merged
merged 4 commits into from
Jun 26, 2024
Merged

mdr+cnv appset pull app and other fixes #9935

merged 4 commits into from
Jun 26, 2024

Conversation

parikshithb
Copy link
Contributor

Adds Appset pull model for cnv apps, fixes issue #9934 and other improvements.

@parikshithb parikshithb added the DR Metro and Regional DR related PRs label Jun 12, 2024
@parikshithb parikshithb self-assigned this Jun 12, 2024
@parikshithb parikshithb requested review from a team as code owners June 12, 2024 10:43
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Jun 12, 2024
@parikshithb parikshithb changed the title mdr+cnv appset pull app apps and other fixes mdr+cnv appset pull app and other fixes Jun 12, 2024
@parikshithb
update1
779524c 
Signed-off-by: Parikshith <[email protected]>
@parikshithb
update2
8945345 
Signed-off-by: Parikshith <[email protected]>
@parikshithb parikshithb added the Needs Testing Run tests and provide logs link label Jun 19, 2024
@parikshithb
update3
63548f1 
Signed-off-by: Parikshith <[email protected]>
@parikshithb
Copy link
Contributor Author

Verified on MDR cluster 4.16 and cnv 4.16.0-2718, both tests passed:

  1. https://url.corp.redhat.com/a834272
  2. https://url.corp.redhat.com/522abfd

@parikshithb parikshithb added Verified Mark when PR was verified and log provided and removed Needs Testing Run tests and provide logs link labels Jun 25, 2024
Akarsha-rai
Akarsha-rai approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@Akarsha-rai Akarsha-rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 25, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Akarsha-rai, parikshithb, PrasadDesala, sidhant-agrawal

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PrasadDesala PrasadDesala merged commit 19b7bca into red-hat-storage:master Jun 26, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidhant-agrawal sidhant-agrawal sidhant-agrawal approved these changes

@PrasadDesala PrasadDesala PrasadDesala approved these changes

@Akarsha-rai Akarsha-rai Akarsha-rai approved these changes

Assignees

@parikshithb parikshithb

@sidhant-agrawal sidhant-agrawal

@PrasadDesala PrasadDesala

@Akarsha-rai Akarsha-rai

Labels
DR Metro and Regional DR related PRs lgtm size/L PR that changes 100-499 lines Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parikshithb @sidhant-agrawal @PrasadDesala @Akarsha-rai