Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.10 support #9995

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

clacroix12
Copy link
Contributor

No description provided.

Signed-off-by: Coady LaCroix <[email protected]>
@clacroix12 clacroix12 added the team/ecosystem Ecosystem team related issues/PRs label Jun 27, 2024
@clacroix12 clacroix12 requested a review from a team June 27, 2024 14:52
@clacroix12 clacroix12 requested a review from a team as a code owner June 27, 2024 14:53
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Jun 27, 2024
@clacroix12
Copy link
Contributor Author

Verified ODF deployment to AWS locally using python 3.10 venv.

@clacroix12 clacroix12 added the Verified Mark when PR was verified and log provided label Jun 27, 2024
@clacroix12
Copy link
Contributor Author

PR Check requirements will be updated just before merging as this needs to happen on the github side.

Copy link

openshift-ci bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: clacroix12, dahorak, petr-balogh, vavuthu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clacroix12 clacroix12 merged commit 47d4f8c into red-hat-storage:master Jun 28, 2024
5 of 6 checks passed
@clacroix12 clacroix12 deleted the python-3.10 branch June 28, 2024 18:49
@petr-balogh
Copy link
Member

@clacroix12 can you please do cherry-picks to all relevant supported branches? So only then we can enforce pr_check for 3.10 in release branches. Vijay has noticed that you have required this for release branches as well, but till we don't have the PR cherry-picked in all release branches, we cannot enforce PR check for 3.10 if it's not there.

Thanks

@clacroix12
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link
Collaborator

@clacroix12: new pull request created: #10020

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@clacroix12
Copy link
Contributor Author

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link
Collaborator

@clacroix12: new pull request created: #10021

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@clacroix12
Copy link
Contributor Author

/cherry-pick release-4.13

@openshift-cherrypick-robot
Copy link
Collaborator

@clacroix12: new pull request created: #10022

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@clacroix12
Copy link
Contributor Author

/cherry-pick release-4.12

@clacroix12 clacroix12 added the backport-required Mark for PRs that need to be backported to older release branches label Jul 2, 2024
@openshift-cherrypick-robot
Copy link
Collaborator

@clacroix12: #9995 failed to apply on top of branch "release-4.12":

Applying: Python 3.10 support
Using index info to reconstruct a base tree...
M	docs/getting_started.md
M	setup.py
Falling back to patching base and 3-way merge...
Auto-merging setup.py
Auto-merging docs/getting_started.md
CONFLICT (content): Merge conflict in docs/getting_started.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Python 3.10 support
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

clacroix12 added a commit to clacroix12/ocs-ci that referenced this pull request Jul 2, 2024
* Python 3.10 support

Signed-off-by: Coady LaCroix <[email protected]>
@clacroix12
Copy link
Contributor Author

Cherry picked to release-4.12 manually here: #10023

clacroix12 added a commit that referenced this pull request Jul 3, 2024
* Python 3.10 support

Signed-off-by: Coady LaCroix <[email protected]>
@clacroix12
Copy link
Contributor Author

@clacroix12 can you please do cherry-picks to all relevant supported branches? So only then we can enforce pr_check for 3.10 in release branches. Vijay has noticed that you have required this for release branches as well, but till we don't have the PR cherry-picked in all release branches, we cannot enforce PR check for 3.10 if it's not there.

Thanks

@petr-balogh Cherry picks to release branches 4.12 - 4.15 have been merged and the branch rules have been updated to expect 4.9 and 4.10 PR checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-required Mark for PRs that need to be backported to older release branches lgtm size/M PR that changes 30-99 lines team/ecosystem Ecosystem team related issues/PRs Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants