Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Allow running GitHub Actions with secrets on external contributor forked PRs.
Link to Related Issue(s)
#338
Please describe the changes in your request.
This change makes actions on pull requests run in the context of the original repo, instead of the context of the fork. This gives the running PR code access to the secrets of the original repo. Since secrets are required for complete test coverage following #338, they will be need for the tests to run on PRs.
To mitigate the risk of users introducing malicious code to PRs to leak and exfiltrate secrets, I have changed the repo settings such that every PR from an external contributor must have the tests be manually run by someone with appropriate repo privileges. In any case, the only secrets are the NXP email and password, which aren't that secret, anyway.
Anyone you think should look at this, specifically?
@whyitfor @paulnoalhyt