Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running forks with secrets #341

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rbs-jacob
Copy link
Member

One sentence summary of this PR (This should go in the CHANGELOG!)

Allow running GitHub Actions with secrets on external contributor forked PRs.

Link to Related Issue(s)

#338

Please describe the changes in your request.

This change makes actions on pull requests run in the context of the original repo, instead of the context of the fork. This gives the running PR code access to the secrets of the original repo. Since secrets are required for complete test coverage following #338, they will be need for the tests to run on PRs.

To mitigate the risk of users introducing malicious code to PRs to leak and exfiltrate secrets, I have changed the repo settings such that every PR from an external contributor must have the tests be manually run by someone with appropriate repo privileges. In any case, the only secrets are the NXP email and password, which aren't that secret, anyway.

Anyone you think should look at this, specifically?

@whyitfor @paulnoalhyt

@rbs-jacob rbs-jacob marked this pull request as ready for review June 28, 2023 22:12
@rbs-jacob rbs-jacob requested a review from whyitfor June 28, 2023 22:18
@rbs-jacob rbs-jacob mentioned this pull request Jun 29, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant