Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UEFI parsing functionality #399

Merged
merged 8 commits into from
Feb 6, 2024

Conversation

Ivanov1ch
Copy link
Contributor

One sentence summary of this PR (This should go in the CHANGELOG!)
WIP Adds the ability to parse UEFI binaries.
Link to Related Issue(s)
N/A
Please describe the changes in your request.
Adds the ability to unpack UEFI binaries using UEFIExtract and a corresponding test case built off UnpackAndVerify (see test_uefi_component.py). Also includes some small typo fixes. Current shortcomings/TODOs:

  • UEFI file format detection has not yet been implemented, so it is being detected as a PE and taking precendence
  • Adds a dependency on UEFIExtract, which has a dependency that is currently missing from the Dockerstub (will not execute).\

Anyone you think should look at this, specifically?
@rbs-jacob

…nstall UEFIExtract (broken, missing a dep), add UEFI asset to test, typo corrections
Copy link
Member

@rbs-jacob rbs-jacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the requested changes below, please also add a CHANGELOG entry for the addition of this functionality.

ofrak_core/Dockerstub Outdated Show resolved Hide resolved
ofrak_core/ofrak/core/uefi.py Show resolved Hide resolved
ofrak_core/test_ofrak/components/test_uefi_component.py Outdated Show resolved Hide resolved
ofrak_core/ofrak/core/uefi.py Outdated Show resolved Hide resolved
ofrak_core/ofrak/core/uefi.py Show resolved Hide resolved
@rbs-jacob rbs-jacob merged commit 6052e9b into redballoonsecurity:master Feb 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants