Modified the FreeSpaceModifier to mark patch bytes written to the binary as not free #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyitfor
force-pushed
the
bugfix/freespace_modifier_mark_patch_as_not_free
branch
3 times, most recently
from
fa1e38c to
bcc8114
Compare
|
@rbs-afflitto, @rbs-alexr, can you please review these update? |
- stub is optional bytes that displace the beginning of the free space - update tests to assert correct functionality of this
whyitfor
force-pushed
the
bugfix/freespace_modifier_mark_patch_as_not_free
branch
from
bcc8114 to
1af5537
Compare
rbs-afflitto
reviewed
Feb 5, 2024
|
I took a look at Andrew's feedback and your fix, it all looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Change
FreeSpaceModifier&PartialFreeSpaceModifierbehavior: an optional stub that isn't free space can be provided and fill-bytes for free space can be specified.Link to Related Issue(s)
N/A.
Please describe the changes in your request.
This changes the signature and intended behavior of the configs for
FreeSpaceModifierandPartialFreeSpaceModifier. Each modifier now allows for injecting a "stub" at the beginning of the targeted code to be freed. This stub is not included in theFreeSpace. The config's "fill" parameter is now the data pattern used to overwrite the bytes that fall in theFreeSpace.Anyone you think should look at this, specifically?
@rbs-afflitto, @rbs-alexr.
Optionally: @rbs-jacob, @EdwardLarson .