Refactor/hexview #427
Refactor/hexview #427
Conversation
There was a problem hiding this comment.
Some outstanding issue that should be fixed before this can be merged.
- Likely due to
Panerefactor, this PR removes padding all over the GUI that should be fixed - The search bar in the tree view is no longer pinned to the top, and scrolls away when you scroll the tree
- The minimap now floats half way between the right of the hex view and the right of the screen when it should be pinned to the right of the screen
- The minimap no longer takes up the full height of the screen, which makes it less practical to use, less easy to see details, etc.
- The minimap and "go to offset" input no longer have a black background, and the hex can be seen around/behind them if the hex area is thin enough to cause overlap
- The "breadcrumb" that used to be at the top of the hex view is no longer visible (it does seem to come back in the disassembly view for some reason)
- The hex view does not allow scrolling past the bottom when using the scroll wheel – I know there is a comment in the code that this is a bug, but I actually ended up kind of preferring it this way
- Scrolling with the mini map does not round to the nearest line correctly (see video at the bottom)
- The bottom of the red "view window" in the minimap is not opaque
- Scrolling in the disassembly view no longer works
- Scrolling in the text view no longer works
Before:
After:
Scrolling not working right:
Screen.Recording.2024-02-23.at.2.03.08.PM.mov
Left button bar lack of background:
Minimap needs background, and should be full height:
Co-authored-by: Jacob Strieb <[email protected]>
Co-authored-by: Jacob Strieb <[email protected]>
Co-authored-by: Jacob Strieb <[email protected]>
Co-authored-by: Jacob Strieb <[email protected]>
Co-authored-by: Jacob Strieb <[email protected]>
There was a problem hiding this comment.
One additional observation about the pane changes is that the vertical and horizontal scrolls are handled differently in a way that I think is potentially confusing for a user. Specifically: there are horizontal scroll bars, but they're way at the bottom and can go out of view. Also if you middle click in the tree with the mouse wheel, it only lets you scroll horizontally.
Similarly, horizontal scrolling the hex view doesn't work if it's too small.
I've included a video, but I don't consider fixing the horizontal scroll critical for this PR. If it's an easy fix, we should do it. But it shouldn't block the PR getting merged.
Screen.Recording.2024-02-27.at.5.37.07.PM.mov
Horizontal scrolling here would be a bit weird, I think the best solution would be to adjust the alignment size based on the hexview element width. In the interest of time, i think this should be a separate PR. |
I'm more concerned about horizontal scrolling in the tree view being weird than about not being able to horizontally scroll the hex view. The only reason I bring them up together is that I think they're likely related. Like I said, no need to block this PR on that. |
Not related, the hex view doesnt "scroll" so i have scrolling totally turned off for that view, if I enable it, it does the "double scroll" that initiated this entire PR. Regardin the resource view, easy fix, theres an |
--------- Co-authored-by: Dan Pesce <[email protected]> Co-authored-by: Jacob Strieb <[email protected]>
One sentence summary of this PR (This should go in the CHANGELOG!)
Link to Related Issue(s)
Please describe the changes in your request.
Anyone you think should look at this, specifically?