Catch PermissionError when checking for dependencies #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a tool or a directory in the PATH environment variable doesn't have the right permissions, it will trigger a PermissionError and cause ofrak to crash while testing for dependencies. Instead, we should catch the error and issue a warning.
rbs-jacob
approved these changes
Mar 14, 2024
rbs-jacob
requested changes
Mar 14, 2024
Adding test case for catching PermissionError when searching for tools in PATH
|
Added a test to |
rbs-jacob
requested changes
Mar 19, 2024
Comment on lines
40
to
41
| found = [r for r in caplog.records if r.message == expected] | ||
| assert len(found) == 1, "Missing error message from component_model" |
There was a problem hiding this comment.
Suggested change
| found = [r for r in caplog.records if r.message == expected] | |
| assert len(found) == 1, "Missing error message from component_model" | |
| assert any(r.message == expected for r in caplog.records), "Missing error message from component_model" |
This way of doing it is a little more concise. Will probably need to re-run the linter after applying the suggestion, though.
There was a problem hiding this comment.
On a second read, my suggested change is not exactly the same as what the original test does, so feel free to resolve this without accepting the edit.
But this particular test is failing in the CI check, so this will have to be revised in some way before we can merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch PermissionError when checking for dependencies, and issue a warning.
Fixes this issue