Remove Instruction.disassembly attribute
#540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyitfor
force-pushed
the
feature/remove_disassembly_field
branch
from
64a58c9 to
38d5103
Compare
whyitfor
force-pushed
the
feature/remove_disassembly_field
branch
from
38d5103 to
0a1faf2
Compare
- Existing usages are replace its with `Instruction.get_assembly()`
whyitfor
force-pushed
the
feature/remove_disassembly_field
branch
from
0a1faf2 to
15ed4c1
Compare
whyitfor
changed the title
Instruction.disassembly attributeInstruction.disassembly attribute
|
Marked as draft for now to address failing tests. One test issue seems to be that the testing packages are importing |
whyitfor
changed the title
Instruction.disassembly attributeInstruction.disassembly attribute
dannyp303
reviewed
Jan 9, 2025
|
Looks good to me! |
dannyp303
approved these changes
Jan 10, 2025
rbs-jacob
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
I think these changes make sense. Relying on a pre-release version is probably a habit we should get into in general – we should always have the source version be a release candidate version a bit ahead of the PyPI version.
Good thinking! I also appreciate that this cleans up the code a good amount.
|
Closes #539. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Instruction.disassemblyattribute. Its usage is replaced with the existingInstruction.get_assembly(), which is equivalent.Instruction.get_assemblyto be synchronous.ofrak==3.3.0rc0,ofrak_capstone==1.1.0rc0to ensure versions of these libraries from PyPI are not used. Update makefilesLink to Related Issue(s)
#539.
Please describe the changes in your request.
See above.
Anyone you think should look at this, specifically?
@dannyp303