Add NamedObjectRef resource to common API #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
This creates a resource that is referenced by name and optionally by namespace. If a namespace field isn't explicitly specified, a parent API is likely injecting the field into the resource and also handles the defaulting behavior of the field. This addresses the use case where a user-facing custom resource does not need to explicitly set a namespace and instead imports that field from a parent API. Previously, the user would have to still create a namespace field and set it to empty due to the namespace field being required by all existing common API resources. This object is comparable to the existing ObjectRef resource except for the fact that namespace is optional.
✅ Checks