[Not Ready] An attempt to update controller-runtime to v0.19 #11
Conversation
| handler.EnqueueRequestForOwner(scheme, testrestmapper.TestOnlyStaticRESTMapper(scheme), &corev1.ConfigMap{}), | ||
| fsmhandler.TriggerTypeChild, | ||
| ) | ||
| } | ||
|
|
||
| t.Run(tc.name, func(t *testing.T) { | ||
| queue := workqueue.NewRateLimitingQueue(workqueue.DefaultControllerRateLimiter()) |
There was a problem hiding this comment.
The new Typed Default controller rate limiter has a delay of 5ms https://github.com/kubernetes/client-go/blob/e421aed7f1b4515185aecebbe101dcfa5fd52997/util/workqueue/default_rate_limiters.go#L50 which will cause the tests to fail unless we sleep for that time.
There was a problem hiding this comment.
What error results from the tests if we don't sleep? Trying to understand the exact mechanics
| ) | ||
| } | ||
|
|
||
| for _, watch := range b.watchesRawSource { |
There was a problem hiding this comment.
kubernetes-sigs/controller-runtime#2783 breaks this interface. They've moved the event handler and predicate arguments out of this method and into the underlying source structs.
Luckily there are only two extant usages of this builder method in achilles codebases (see here, reddit/achilles and reddit/achilles-cassandra-controller)
My proposal to fix this would be to:
- update the SDK builder's
WatchesRawSourceto match the controller-runtime interface (this is a break glass code interface) - add an SDK builder method
WatchesInformerthat takes asource.Informer. The implementation then wraps thissource.Informerwith a newsource.Informerthat injects the observed event handler (used byreddit/achilles) - same as 2 but
WatchesChannel(used byreddit/achilles-cassandra-controller)
Closes #
💸 TL;DR
📜 Details
Design Doc
Jira
🧪 Testing Steps / Validation
✅ Checks