Introduce an error for trying to fetch a secret of the wrong type. #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folone
requested review from
fishy,
kylelemons and
konradreiche
and removed request for
a team
fishy
requested changes
Feb 5, 2024
folone
force-pushed
the
gl/secret-wrong-type-error
branch
from
d3e6efc to
1d65457
Compare
fishy
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
This PR introduces a new error for attempting to fetch a secret of the wrong type:
I've seen this issue recently, and had a few infra folks trying to debug why secrets are not being fetched. Turned out they were, but I was using the wrong API (
GetSimpleSecretinstead ofGetVersionedSecret). This change would've avoided this whole situation.🧪 Testing Steps / Validation
Added a unit test.
✅ Checks