kafkabp: Support AWS IMDS v2 for rack id #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishy
requested review from
kylelemons,
konradreiche and
pacejackson
and removed request for
a team
fishy
force-pushed
the
kafkabp-aws-rack-imds-v2
branch
from
5182e4a to
41f1885
Compare
kylelemons
approved these changes
Jun 11, 2024
| const ( | ||
| // References: | ||
| // https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instancedata-data-retrieval.html | ||
| // https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instancedata-data-categories.html |
There was a problem hiding this comment.
🔕 is there a reference for the IMDSv2 / token API to add?
| tokenURL = "http://169.254.169.254/latest/api/token" | ||
| azURL = "http://169.254.169.254/latest/meta-data/placement/availability-zone" | ||
|
|
||
| timeout = time.Second |
There was a problem hiding this comment.
🔕 I think units should always come with a scalar too for readability, even if it's 1
Suggested change
| timeout = time.Second | |
| timeout = 1*time.Second |
| ctx, cancel := context.WithTimeout(context.Background(), timeout) | ||
| defer cancel() | ||
|
|
||
| token, err := func(ctx context.Context) (string, error) { |
There was a problem hiding this comment.
Same comments as the rack API: not sure I am seeing the reason for the anonymous function, and that header should be normalized
| id, err := awsRackID() | ||
| if err != nil { | ||
| awsRackFailure.Inc() | ||
| slog.Warn("Failed to get AWS availability zone as rack id", "err", err) |
There was a problem hiding this comment.
🔕 is v0 ready for slog?
There was a problem hiding this comment.
I think we want to gradually shift v0 to use slog directly, which will use ctxlog if services have ctxlog set up in their main (as v0 cannot use ctxlog directly)
fishy
force-pushed
the
kafkabp-aws-rack-imds-v2
branch
from
41f1885 to
94d07bd
Compare
Also modernize the code a bit (use sync.OnceValues, etc.).
fishy
force-pushed
the
kafkabp-aws-rack-imds-v2
branch
from
94d07bd to
379642d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also modernize the code a bit (use sync.OnceValues, etc.).