Use Self type in _BaseKafkaQueueConsumerFactory.new() (#894)

reddit · Apr 29, 2024 · 16e3934 · 16e3934
1 parent 08af744
commit 16e3934
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 13 deletions.
diff --git a/baseplate/frameworks/queue_consumer/kafka.py b/baseplate/frameworks/queue_consumer/kafka.py
@@ -19,6 +19,7 @@
 from prometheus_client import Counter
 from prometheus_client import Gauge
 from prometheus_client import Histogram
+from typing_extensions import Self
 
 from baseplate import Baseplate
 from baseplate import RequestContext
@@ -268,7 +269,7 @@ def new(
         health_check_fn: Optional[HealthcheckCallback] = None,
         kafka_config: Optional[Dict[str, Any]] = None,
         prometheus_client_name: str = "",
-    ) -> "_BaseKafkaQueueConsumerFactory":
+    ) -> Self:
         """Return a new `_BaseKafkaQueueConsumerFactory`.
 
         This method will create the :py:class:`~confluent_kafka.Consumer` for you and is

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -38,6 +38,7 @@ requests = ">=2.21.0,<3.0"
 sentry-sdk = { version = ">=1.35.0,<2.0", optional = true }
 sqlalchemy = { version = ">=1.4.49,<2", optional = true }
 thrift-unofficial = ">=0.19.0,<1.0"
+typing-extensions = "^4.11.0"
 
 [tool.poetry.extras]
 amqp = ["kombu"]