This repository is currently being migrated. It's locked while the migration is in progress.
Prefer builtins over some typing aliases #1001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanBalfanz
force-pushed
the
prefer-builtins-over-deprecated-typing-aliases
branch
from
be2556f to
d83d813
Compare
This is an incremental replacement of `typing.Dict` with `builtins.dict`, `typing.List` with `builtins.list`, `typing.Set` with `builtins.set`, and `typing.Tuple` with `builtins.tuple`, though other aliases exist which. See: https://docs.python.org/3/library/typing.html#deprecated-aliases
RyanBalfanz
force-pushed
the
prefer-builtins-over-deprecated-typing-aliases
branch
from
a27fd27 to
3ca263c
Compare
|
@RyanBalfanz it looks like a lot of these were converted by Ruff already, do you think we still need this PR? |
If Ruff took care of it, then great! I'll take a look to see if anything my have been missed and create a new PR if so. |
|
I took a look; this is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an incremental replacement of
typing.Dictwithbuiltins.dict,typing.Listwithbuiltins.list,typing.Setwithbuiltins.set, andtyping.Tuplewithbuiltins.tuple, though other aliases exist which.See: https://docs.python.org/3/library/typing.html#deprecated-aliases
Deprecated since version 3.9, as such, this change makes sense to follow #1002 which makes version 3.9 the oldest supported version though the aliases are guaranteed to remain in the typing module without deprecation warnings until at least Python 3.14.
Closes #
💸 TL;DR
📜 Details
Design Doc
Jira
🧪 Testing Steps / Validation
✅ Checks