Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with Docker Desktop on Windows #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MuellerKlaus
Copy link

Automatic line conversion makes sha256sum fail if build on Windows

💸 TL;DR

sha256sum fails to run if project checked out from Windows with automatic line ending conversion. The change mark the 'checksums.txt' file as non-text.

📜 Details

N/A

🧪 Testing Steps / Validation

  • checkout repo on Windows system with git
  • try to run 'docker build --progress plain .'
  • build fails with 'sha256sum: checksums.txt: no file was verified'
  • build succeed after set git attributes

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

Automatic line conversion makes sha256sum fail if build on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant