Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/lexical binding #37

Merged
merged 20 commits into from
Oct 19, 2024
Merged

Feat/lexical binding #37

merged 20 commits into from
Oct 19, 2024

Commits on Oct 17, 2024

  1. Enable lexical binding

    @joshbax189
    joshbax189 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e01b753 View commit details
    Browse the repository at this point in the history

  2. Ignore string arg to js-comint-filter-output 

    It just changes the output in the comint buffer.
    @joshbax189
    joshbax189 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    cc6a360 View commit details
    Browse the repository at this point in the history

  3. Lint and simplify js-comint-repl 

    require does not load if already present.
Convert cond to equivalent if
    @joshbax189
    joshbax189 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    ed7e77a View commit details
    Browse the repository at this point in the history

  4. Add lexical-binding and requires to test

    @joshbax189
    joshbax189 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    d9088c3 View commit details
    Browse the repository at this point in the history

  5. Bug: js-comint--suggest-module-path should be nil if no node_modules 

    This means that default-directory is always added to NODE_PATH
when calling js-comint-repl
    @joshbax189
    joshbax189 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    ceeb9eb View commit details
    Browse the repository at this point in the history

  6. Use temporary local env vars when calling comint 

    This avoids modifying NODE_PATH for later calls
    @joshbax189
    joshbax189 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    addff71 View commit details
    Browse the repository at this point in the history

  7. Remove unused js-comint-setup-module-paths

    @joshbax189
    joshbax189 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    3d879f5 View commit details
    Browse the repository at this point in the history

  8. Depend on emacs 28.1 to use with-environment-variables

    @joshbax189
    joshbax189 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    2eceaf3 View commit details
    Browse the repository at this point in the history

  9. Tidy argument handling for js-comint-repl 

    Made cmd optional and documented behaviour.
    @joshbax189
    joshbax189 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    18ab673 View commit details
    Browse the repository at this point in the history

  10. Add missing customization types to fix compiler warnings

    @joshbax189
    joshbax189 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e83eb27 View commit details
    Browse the repository at this point in the history

  11. Add unit tests for js-comint-start-or-switch-to-repl

    @joshbax189
    joshbax189 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    2058be8 View commit details
    Browse the repository at this point in the history

  12. Simplify js-comint--suggest-module-path 

    read-directory-name defaults to default-directory if nil
and expand-file-name produces output equivalent to file-truename.
    @joshbax189
    joshbax189 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    dd6c117 View commit details
    Browse the repository at this point in the history

  13. Have js-comint-start-or-switch-to-repl check local node_modules 

    This way js-rest-repl does not "forget" the local node_modules.
    @joshbax189
    joshbax189 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    951131c View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Fix failing test

    @joshbax189
    joshbax189 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    be24e8e View commit details
    Browse the repository at this point in the history

  2. Factor out process exit logic in tests

    @joshbax189
    joshbax189 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7ceec3d View commit details
    Browse the repository at this point in the history

  3. Add declares for nvm functions. 

    This fixes byte-compiler warnings, but keeps nvm optional
    @joshbax189
    joshbax189 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    8f05c1b View commit details
    Browse the repository at this point in the history

  4. Move (require 'nvm) into select-node-version, tidy logic 

    js-comint-select-node-version is the common entry point when using
nvm functions.
    @joshbax189
    joshbax189 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7fbcb4b View commit details
    Browse the repository at this point in the history

  5. Message when changing cmd while nvm is set

    @joshbax189
    joshbax189 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    1c3b1ab View commit details
    Browse the repository at this point in the history

  6. Do not include empty strings in path

    @joshbax189
    joshbax189 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    6eaa359 View commit details
    Browse the repository at this point in the history

  7. Switch buffers in start-or-switch-to-buffer

    @joshbax189
    joshbax189 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    4353fe2 View commit details
    Browse the repository at this point in the history