Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how to access rhoai instructions #26

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Aug 13, 2024

Simply adds more information about how to access the Openshift AI & the created workbench

Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
@thepetk thepetk requested a review from johnmcollier August 13, 2024 15:38
Copy link
Contributor

@johnmcollier johnmcollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just a couple minor comments

@thepetk
Copy link
Contributor Author

thepetk commented Aug 14, 2024

Overall looks good, just a couple minor comments

@johnmcollier I've tried to address the comments. A qq from my side is if I have to include in my PR all items created by the generate.sh script. I see there's also template/rag/* items included.

@johnmcollier
Copy link
Contributor

johnmcollier commented Aug 14, 2024

@thepetk Nope, if there's things you don't want to include, that's fine. Since this change is just scoped to the techdoc changes, let's just include those. We don't need the CI passing to merge.

@thepetk
Copy link
Contributor Author

thepetk commented Aug 14, 2024

@thepetk Nope, if there's things you don't want to include, that's fine. Since this change is just scoped to the techdoc changes, let's just include those. We don't need the CI passing to merge.

Ok nice! I think then I have included all necessary items :)

@thepetk thepetk merged commit f513321 into redhat-ai-dev:main Aug 14, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants