build-definitions update

[rh-tap-build-team]

Included PRs:

• Update ignore konflux-ci/build-definitions#907
• Get changed task files for git resolvers konflux-ci/build-definitions#888
• Revert "Get changed task files for git resolvers" konflux-ci/build-definitions#910
• e2e-tests update konflux-ci/build-definitions#897
• Give write permission to e2e-tests task konflux-ci/build-definitions#883
• Retry tkn bundle push konflux-ci/build-definitions#896
• e2e-tests update konflux-ci/build-definitions#919
• enterprise contract update konflux-ci/build-definitions#916
• hack/build-and-push.sh: fix digest existence check konflux-ci/build-definitions#904
• Get changed task files for git resolvers konflux-ci/build-definitions#915
• Clarify ec task usage in this repo konflux-ci/build-definitions#902
• Add a buildah task step that generates base images sbom konflux-ci/build-definitions#862
• Properly handle GitLab merge request event in RHTAP pipeline konflux-ci/build-definitions#921
• Save base_images_from_dockerfile to /workspaces/source konflux-ci/build-definitions#922

[mkosiarc]

/approve
/lgtm

[mkosiarc]

Seems there is a valid error

      container step-create-base-images-sbom: 
      Traceback (most recent call last):
        File "/app/base_images_sbom_script.py", line 140, in <module>
          main()
        File "/app/base_images_sbom_script.py", line 119, in main
          base_images_from_dockerfile = args.base_images_from_dockerfile.read_text().splitlines()
        File "/usr/lib64/python3.9/pathlib.py", line 1266, in read_text
          with self.open(mode='r', encoding=encoding, errors=errors) as f:
        File "/usr/lib64/python3.9/pathlib.py", line 1252, in open
          return io.open(self, mode, buffering, encoding, errors, newline,
        File "/usr/lib64/python3.9/pathlib.py", line 1120, in _opener
          return self._accessor.open(self, flags, mode)
      FileNotFoundError: [Errno 2] No such file or directory: '/workspace/base_images_from_dockerfile'

I'll investigate, it's happening for multi platform builds that uses buildah-remote task

[mkosiarc]

Already prepared PR that should fix this konflux-ci/build-definitions#922

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkosiarc, rcerven, rh-tap-build-team[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/build-service/base/build-pipeline-selectors/OWNERS [mkosiarc,rcerven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mkosiarc]

/test appstudio-hac-e2e-tests

[mkosiarc]

/test appstudio-e2e-tests-ocp-4-14

[openshift-ci]

@rh-tap-build-team[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/appstudio-hac-e2e-tests	5dc9a82	link	false	/test appstudio-hac-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[mkosiarc]

/lgtm