Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-definitions update #4876

Merged
merged 1 commit into from
Nov 12, 2024
Merged

build-definitions update #4876

merged 1 commit into from
Nov 12, 2024

Conversation

@arewm
Copy link
Contributor

arewm commented Nov 12, 2024

/lgtm

@arewm
Copy link
Contributor

arewm commented Nov 12, 2024

/retest-required

@arewm
Copy link
Contributor

arewm commented Nov 12, 2024

/approved

@arewm arewm added the approved label Nov 12, 2024
Copy link

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: rh-tap-build-team[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorhun
Copy link
Member

mmorhun commented Nov 12, 2024

/test appstudio-e2e-tests

@arewm
Copy link
Contributor

arewm commented Nov 12, 2024

/retest-required

@arewm
Copy link
Contributor

arewm commented Nov 12, 2024

/lgtm

@openshift-ci openshift-ci bot added lgtm and removed lgtm labels Nov 12, 2024
@arewm
Copy link
Contributor

arewm commented Nov 12, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 12, 2024
@flacatus
Copy link
Contributor

LGTM

@arewm
Copy link
Contributor

arewm commented Nov 12, 2024

We would like to include konflux-ci/build-definitions#1600 as well but the push pipeline seems to be hanging...

@arewm
Copy link
Contributor

arewm commented Nov 12, 2024

@flacatus , if you feel like you should force merge this PR, we can always do similar to the next as well.

Copy link

openshift-ci bot commented Nov 12, 2024

@rh-tap-build-team[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-e2e-tests 97690d7 link true /test appstudio-e2e-tests
ci/prow/appstudio-upgrade-tests 97690d7 link false /test appstudio-upgrade-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot removed the lgtm label Nov 12, 2024
@arewm
Copy link
Contributor

arewm commented Nov 12, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 12, 2024
@flacatus flacatus merged commit c2878f6 into main Nov 12, 2024
3 of 6 checks passed
@arewm arewm deleted the build-definitions branch November 12, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants