fix(KFLUXINFRA-777): Changing NodeSelector and Toleration for Staging Overlay #4904
Conversation
|
|
||
|
|
There was a problem hiding this comment.
A bit of nitpicking, but do we really need these two empty lines ?
There was a problem hiding this comment.
Thanks to your microscopic assessment, I have removed one of thise line.
yamllint configs/nvme-storage-configurator/staging/patch.yaml throws no error now. There quite a few earlier.
|
@manish-jangra Can you please associate this change with a JIRA issue ? |
manish-jangra
force-pushed
the
nvme-config-change
branch
from
7ddb870
to
fb82573
Compare
manish-jangra
changed the title
@eisraeli attached the jira item now. |
|
@manish-jangra: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bamachrn, hugares, manish-jangra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We're replacing nodes with EBS Volumes to the nodes with Local NVMe Disks as default node pool.