etcd-shield: fix metrics in staging #6834
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadlerap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
sadlerap
force-pushed
the
etcd-shield-metrics-staging
branch
from
9c01ece to
30b0bb0
Compare
|
/retest |
1 similar comment
|
/retest |
|
/retest @filariow do you have any ideas why e2e tests might be failing? None of the components that fail are related to |
|
/retest |
|
try rebasing on |
Metrics for etcd-shield were misconfigured in two ways. First, the labels selectors were incorrect and not applied to the relevant service. Applying the correct labels and label selectors allows the servicemonitor to pick up the correct metrics endpoints. Second, because etcd-shield is run not as a user workload but as a core service, the prometheus-k8s service account in the namespace `openshift-monitoring` needs to be given appropriate permissions to look at resources in the `etcd-shield` namespace. This is fixed by adding a role and a rolebinding. Signed-off-by: Andy Sadler <[email protected]>
sadlerap
force-pushed
the
etcd-shield-metrics-staging
branch
from
30b0bb0 to
d4bbc1b
Compare
|
@sadlerap: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Metrics for etcd-shield were misconfigured in two ways. First, the labels selectors were incorrect and not applied to the relevant service. Applying the correct labels and label selectors allows the servicemonitor to pick up the correct metrics endpoints. Second, because etcd-shield is run not as a user workload but as a core service, the prometheus-k8s service account in the namespace
openshift-monitoringneeds to be given appropriate permissions to look at resources in theetcd-shieldnamespace. This is fixed by adding a role and a rolebinding.