Refactor pipelines as code config Kustomization to DRY common values #6851
+158
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously every cluster used a kustomize patch to add the PaC settings object to the TektonConfig. Since most of the values were unique per cluster this was fine. However as global settings like `remember-ok-to-test` and `secret-github-app-token-scope` have been set, there is no need to duplicate the entire settings block per cluster. Instead, we can use Kustomize to override just the settings which are cluster-specific
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aThorp96 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously every cluster used a kustomize patch to add the PaC settings object to the TektonConfig. Since most of the values were unique per cluster this was fine. However as global settings like
remember-ok-to-testandsecret-github-app-token-scopehave been set, there is no need to duplicate the entire settings block per cluster. Instead, we can use Kustomize to override just the settings which are cluster-specificPlease note that the after refactoring the settings there are no substantive changes to the PaC config in each deployment, except for several clusters in which
remember-ok-to-testwas not propogated (kflux-ocp-p01, kflux-prd-rh02,kflux-prd-rh03`, and all but one staging cluster).