Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't verify redhat-appstudio/dance-bootstrap-app #53

Conversation

simonbaird
Copy link
Contributor

@simonbaird simonbaird commented Aug 7, 2024

Making this patch in the Tekton task to be consistent with redhat-appstudio/tssc-sample-jenkins#4

(There should also be an upstream PR in the build-definitions repo.)

As mentioned elsewhere, I'm not sure if this is a good solution, (or if this bug would actually be a real problem in production), but I'm proposing this change as a quick workaround RHTAPBUGS-1284 for to help get testing unblocked.

Ref: https://issues.redhat.com/browse/RHTAPBUGS-1284

Making this patch in the Tekton task to be consistent with
redhat-appstudio/tssc-sample-jenkins#4

(There should also be an upstream PR in the build-definitions repo.)

As mentioned elsewhere, I'm not sure if this is a good solution, (or
if this bug would actually be a real problem in production), but I'm
proposing this change as a quick workaround RHTAPBUGS-1284 for to
help get testing unblocked.

Ref: https://issues.redhat.com/browse/RHTAPBUGS-1284
Copy link

openshift-ci bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: simonbaird
Once this PR has been reviewed and has the lgtm label, please assign xinredhat for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Aug 7, 2024

@simonbaird: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhtap-sample-pipelines-yamllint 7b93515 link false /test rhtap-sample-pipelines-yamllint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@simonbaird
Copy link
Contributor Author

Draft until we see what happens with redhat-appstudio/tssc-sample-jenkins#4 and redhat-appstudio/tssc-sample-jenkins#5 .

@simonbaird
Copy link
Contributor Author

Replaced by #54 .

@simonbaird simonbaird closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant