-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding tests and logic #104
base: main
Are you sure you want to change the base?
Conversation
684a39d
to
7c1b6ac
Compare
You can try to make them both offset naive : |
878eb9b
to
7d9d04a
Compare
Signed-off-by: rimonsh <[email protected]>
Signed-off-by: rimonsh <[email protected]>
Signed-off-by: rimonsh <[email protected]>
Signed-off-by: rimonsh <[email protected]>
7d9d04a
to
98c7574
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, I Just added a small idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe consider to add a field that tracks the number of votes each suggestion receives. This addition can provide valuable data for evaluating the popularity for each suggestion. Or you thought of alternative way for determining the chosen suggestion?
What this PR does?
This PR I tested Poll suggestion Saving to django DB, whether it's in the past , or there's already a suggestion in the same time.
Notes for reviewer
I would be more than happy to hear more suggestions on how to check if suggested time is in the past (less than datetime.now() ).
For some reason, the line "if self.time < timezone.now():" is not passing.
Related Issue
Resolves #103
Test coverage
-Testing suggested time is not in the past.
-Testing that there's no other suggestion like it in the same poll.