-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: build 11ty site for tutorial and statement of work #19
base: main
Are you sure you want to change the base?
Conversation
links: | ||
- heading: המוצרים שלנו | ||
links: | ||
- href: https://www.redhat.com/en/technologies/management/ansible | ||
content: Red Hat Ansible Automation Platform | ||
- href: https://www.redhat.com/en/technologies/linux-platforms/enterprise-linux | ||
content: Red Hat Enterprise Linux | ||
- href: https://www.redhat.com/en/technologies/cloud-computing/openshift | ||
content: Red Hat OpenShift | ||
- href: https://www.redhat.com/en/technologies/cloud-computing/openshift-data-foundation | ||
content: Red Hat OpenShift Data Foundation | ||
- href: https://www.redhat.com/en/technologies/linux-platforms/openstack-platform | ||
content: Red Hat OpenStack Platform | ||
- href: https://www.redhat.com/en/technologies/all-products | ||
content: See all products |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this for beyond?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can either:
- replace the footer content/links with something more appropriate
- remove the main footer and use only the global (i.e. legal) footer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we leave this for a subsequent PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no option for me, as "tech dumb" to track the amount of changes.
I think that @ifireball offline suggestions are correct:
...
I would split that work into at least 4-5 separate PRs:
1. Suggest changes to the doc
2. Add 11ty in "Hello World" state - so only generated files
3. Add/move SOW files
4. Add/move challenges doc files
...
My extra 2 cents here:
- This is how a contributor promotes his PR/MR in OS communities for fast approvals.
- In Agile methodologies, we are breaking down the pieces to achieve constant delivery.
(PR is not moving forward quite long) - In addition as Beyond mentors we should lead by example.
I hope
I would also recommend to keep the content independent of the presentation layer as much as possible. |
Atomic commits
I certainly sympathize with the need to review atomic changes in this PR. It happens to be that the commits in this PR are already atomic, so you might consider reviewing them one-by-one, which will allow you to review the changes in smaller chunks. ex post facto, it would certainly have been better to take that approach, but as it is, picking apart this PR would take about the same amount of time as the original work - there is not a lot of code here - so since the changes here are small in the grand scheme of things, and the time it would take to split the existing atomic commits into separate PRs could be better spent on other things, and since this is a volunteer project, if there is room to be a little flexible in reviewing this PR, I would very much appreciate it. I'm also available to walk through the changes one-on-one if desired. Content and Presention
This is already the case in this PR. The content is markdown with frontmatter, the style and layout is all in the HTML templates, CSS, and eleventy config, according to Red Hat brand standards Maintenancetl;dr: there are basically 0 lines of build JS, and less than 200 lines of HTML for beyond to maintain here. Aside from the content, the PR contains:
That's not a tremendous amount of software to maintain, in my opinion. As well, the need for maintenance here is minimal, as software only runs in CI/CD, and there is very little security attack surface. |
As an aid to review, since deploy previews will only function if this PR is merged for subsequent PRs, I've attached to this message an archive of the site as built just now. unzip it and run a local webserver of your choice to review the site, or follow the instructions in README.md to build it yourself |
@Yarboa WRT splitting the PR, we have another reason not to retroactively split this PR up. As we learned from @ifireball in mentor training this morning (oct 2), PRs should deliver the minimum complete feature, there's no need for example to split PRs into model changes, then view changes, then controller changes. Rather it's preferable to create a single PR for "adding users". Similarly, there's no need here to split the PR into one for installing dependencies, another for adding CSS, and a third for translating content. Should this PR therefore contain any arbitrary changes? No, an example of a follow up PR would be to update the styles, to upstream the RHDS eleventy plugin, to build a home page, to add different content, etc. |
Per our one-on-one @ifireball, I've updated the readme. I also moved some code out of the local templates and into the plugin, so that a future PR can remove more code from this repo. Updated preview: |
Sorry, but i do not find the time to review this PR, hence dismissing my review to others
The cost of splitting changes is always raised as a reason not to do them.
I have noticed changes (the frontmatter?) that are not compatible with GitHub MD representation.
This is relative to the available knowledge and familiarity.
I'm also unclear what does it mean that it runs only in CI. It runs also when users are accessing the pages, no? Just to be clear, I am not against this initiative at all, I think it is a good step forward. Personally, I would have preferred all non content parts be placed in a separate repo, but I understand this may not be possible with the existing tooling. |
I think this is a an interpretation of what is minimum, complete and a feature. Generally, I would say that small PR/s have a better chance to get in than bigger PR/s. BTW, this is also a point to consider, you need someone who understand the changes in order to review and approve. A maintainer is suppose to approve these changes when the maintainer is willing to support it (or trusts someone to support it). |
FWIW github displays the frontmatter as a table. the shortcodes will just dump raw, since gh doesn't parse liquid-style curly tags
devs involved in the israel site (which i had previously offered to host this there, mind you)
israel site, ux.redhat.com, others
it's open source, check out their docs site to see who's using it. doesn't need updates because it only runs in ci
No, it literally only runs in ci. the build generates static files, which are accessible until updated, regardless of the status of subsequent builds.
the github action just runs the node scripts. no need to update. also, if CI breaks, the content will still be available, it just wont be updated, since the build only runs in ci and generates static files. |
@bennypowers As far as an 11ty build, it looks pretty straight forward and well structured. Content is segmented into distinct folders, just using headmatter to provide metadata about the page. Layouts are separated from content using the I'm not exactly sure what the history of this repo is but if it's to allow content contributors to edit markdown files in github and have those changes automatically published to a website then this looks like a good solution. We use 11ty for this exact workflow a lot and really enjoy it. |
The design systems team works with these technologies a lot and has a wide base of experience, we're available if there are any issues. 🙂 |
Have we received sufficient assurances yet? Can this merge so we can iterate? |
What I did
This PR transforms both the statements-of-work (markdown, this repo) and the introductory tutorial (google doc, corporate google drive) into a website that uses red hat design system to provide a consistent and pleasant experience
Goals
Non-goals