Skip to content

Commit

Permalink
add checking of mandatory fields in pubsub (#113) (#114)
Browse files Browse the repository at this point in the history
Signed-off-by: Jack Ding <[email protected]>
  • Loading branch information
jzding authored Dec 20, 2024
1 parent 225a3d2 commit 64a81e9
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion pkg/pubsub/pubsub_unmarshal.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
package pubsub

import (
"fmt"
"io"
"sync"

Expand Down Expand Up @@ -91,7 +92,14 @@ func readJSONFromIterator(out *PubSub, iterator *jsoniter.Iterator) error {
if iterator.Error != nil {
return iterator.Error
}

// Skip checking EndPointURI here since it is not used in http transport.
// Check EndPointURI in O-RAN REST API handler
//if endpointUri == "" {
// return fmt.Errorf("mandatory field EndPointURI is not set")
//}
if resource == "" {
return fmt.Errorf("mandatory field ResourceAddress is not set")
}
out.SetID(id)
out.SetEndpointURI(endpointUri) //nolint:errcheck
out.SetURILocation(uriLocation) //nolint:errcheck
Expand Down

0 comments on commit 64a81e9

Please sign in to comment.