Merge pull request #108 from abikouo/fix_unsafe_condition

fix unsafe assert
redhat-cop · Dec 12, 2023 · fcab549 · fcab549
2 parents 3a5424f + 4166e6f
commit fcab549
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/tests/integration/targets/test_awsconfig_apigateway_with_lambda_integration/tasks/main.yml b/tests/integration/targets/test_awsconfig_apigateway_with_lambda_integration/tasks/main.yml
@@ -45,7 +45,7 @@
     - name: Ensure result is as expected
       ansible.builtin.assert:
         that:
-          - __uri_result.json == "Running ansible-test with Resource prefix {{ resource_prefix }}"
+          - __uri_result.json == "Running ansible-test with Resource prefix "+resource_prefix
 
     # Test: Delete API gateway
     - name: Delete API Gateway

diff --git a/tests/integration/targets/test_backup_select_resources/tasks/main.yml b/tests/integration/targets/test_backup_select_resources/tasks/main.yml
@@ -101,7 +101,7 @@
       ansible.builtin.assert:
         that:
           - result.backup_selections | length == 2
-          - result.backup_selections[1].selection_name == "{{ selection_two }}"
+          - result.backup_selections[1].selection_name == selection_two
           - result.backup_selections[1].resources == ["*"]
           - result.backup_selections[1].not_resources == ["arn:aws:rds:*:*:db:*"]
           - result.backup_selections[1].list_of_tags | length == 0

diff --git a/tests/integration/targets/test_create_rds_global_cluster/tasks/main.yml b/tests/integration/targets/test_create_rds_global_cluster/tasks/main.yml
@@ -57,12 +57,12 @@
     - name: Verify resources are created successfully
       ansible.builtin.assert:
         that:
-          - global_cluster_info.result.identifier == "{{ test_global_cluster_name }}"
+          - global_cluster_info.result.identifier == test_global_cluster_name
           - global_cluster_info.result.properties.source_db_cluster_identifier == primary_cluster_info.clusters[0].db_cluster_arn
-          - primary_cluster_info.clusters[0].db_cluster_identifier == "{{ test_primary_cluster_name }}"
-          - "'{{ test_primary_cluster_region }}' in primary_cluster_info.clusters[0].availability_zones[0]"
-          - replica_cluster_info.clusters[0].db_cluster_identifier == "{{ test_replica_cluster_name }}"
-          - "'{{ test_replica_cluster_region }}' in replica_cluster_info.clusters[0].availability_zones[0]"
+          - primary_cluster_info.clusters[0].db_cluster_identifier == test_primary_cluster_name
+          - test_primary_cluster_region in primary_cluster_info.clusters[0].availability_zones[0]
+          - replica_cluster_info.clusters[0].db_cluster_identifier == test_replica_cluster_name
+          - test_replica_cluster_region in replica_cluster_info.clusters[0].availability_zones[0]
           - replica_cluster_info.clusters[0].replication_source_identifier == primary_cluster_info.clusters[0].db_cluster_arn
 
   always: