Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[integration] Enable integration tests via Github actions #39

Merged
merged 9 commits into from
Jul 3, 2023
Merged

[integration] Enable integration tests via Github actions #39

merged 9 commits into from
Jul 3, 2023

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Jun 20, 2023 •
edited
Loading

This pull request contains multiple changes

  • Add GH workflow for integration tests
  • Add integration tests for role ec2_instance_terminate_by_tag
  • Rename some roles variable to fix ansible-lint issues
  • Stabilize integration tests

Integration tests have been tested via #38

@abikouo abikouo requested a review from gravesm June 30, 2023 15:36
@gravesm gravesm self-requested a review June 30, 2023 17:06
gravesm
gravesm requested changes Jun 30, 2023
View reviewed changes
Copy link
Member

@gravesm gravesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, didn't mean to approve. Would still like to see the ami tests enabled.

@abikouo abikouo requested a review from gravesm July 3, 2023 10:23
@abikouo abikouo merged commit d14bb0a into main Jul 3, 2023
24 checks passed
@abikouo abikouo deleted the stable-ci-1 branch July 5, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gravesm gravesm gravesm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abikouo @gravesm