Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backup plan role #45

Merged
merged 11 commits into from
Jul 26, 2023
Merged

Conversation

hakbailey
Copy link
Collaborator

SUMMARY

Adds roles to create a backup plan/vault and to select resources for backup.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • backup_create_plan
  • backup_select_resources

Copy link
Contributor

@abikouo abikouo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for the tests to be executed, you need to add an aliases file with cloud/aws

roles/backup_create_plan/tasks/main.yaml Outdated Show resolved Hide resolved
roles/backup_create_plan/defaults/main.yaml Outdated Show resolved Hide resolved
roles/backup_create_plan/defaults/main.yaml Outdated Show resolved Hide resolved
roles/backup_create_plan/tasks/main.yaml Outdated Show resolved Hide resolved
roles/backup_create_plan/tasks/main.yaml Outdated Show resolved Hide resolved
roles/backup_select_resources/tasks/main.yaml Outdated Show resolved Hide resolved
roles/backup_select_resources/vars/main.yaml Show resolved Hide resolved
@hakbailey
Copy link
Collaborator Author

hakbailey commented Jul 3, 2023

In order for the tests to be executed, you need to add an aliases file with cloud/aws

It doesn't look like the other test targets in this repo have that, why is it needed for these?
Update: nevermind, I was working from an outdated branch :)

What does time represent in the aliases file?

@abikouo
Copy link
Contributor

abikouo commented Jul 3, 2023

In order for the tests to be executed, you need to add an aliases file with cloud/aws

It doesn't look like the other test targets in this repo have that, why is it needed for these? Update: nevermind, I was working from an outdated branch :)

What does time represent in the aliases file?

The cloud/aws is a way to tell to ansible-test that we need AWS credentials to run the target.
The time= is not used for now but can be used later to split targets into multiple workflows

@hakbailey hakbailey marked this pull request as draft July 3, 2023 22:08
@hakbailey hakbailey marked this pull request as ready for review July 4, 2023 21:35
@hakbailey hakbailey requested a review from abikouo July 4, 2023 21:35
@hakbailey
Copy link
Collaborator Author

@abikouo do you know why the test_customized_ami test is failing? I rebased this branch onto main today so it should have the latest changes.

@abikouo
Copy link
Contributor

abikouo commented Jul 5, 2023

@abikouo do you know why the test_customized_ami test is failing? I rebased this branch onto main today so it should have the latest changes.

@hakbailey the integration target is failing because of missing required RSA keys. I have created a PR to fix that #48

@alinabuzachis
Copy link
Contributor

@hakbailey Please update also https://github.com/redhat-cop/cloud.aws_ops#roles because it is not automatically generated.

@abikouo
Copy link
Contributor

abikouo commented Jul 6, 2023

@hakbailey need target are not executed, I am going to investigate why

@hakbailey
Copy link
Collaborator Author

@hakbailey need target are not executed, I am going to investigate why

@abikouo any updates on this?

@abikouo
Copy link
Contributor

abikouo commented Jul 26, 2023

@hakbailey need target are not executed, I am going to investigate why

@abikouo any updates on this?

The integration workflow does not checkout the pull request head branch this is the reason why the new target is not visible by ansible-test, #58 should solve that

@hakbailey hakbailey merged commit ce1c5c3 into redhat-cop:main Jul 26, 2023
22 checks passed
@hakbailey hakbailey deleted the add-backup-plan-role branch July 26, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants