Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manage_vpc_peering: fix integration tests, update role var names #61

Merged
merged 5 commits into from
Jul 27, 2023

Conversation

mandar242
Copy link
Contributor

Fix integration tests for manage_vpc_peering role.

@mandar242 mandar242 requested a review from gravesm July 12, 2023 21:03
Copy link
Member

@gravesm gravesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the linting error, looks good. Not sure what's going on with the integration tests.

@mandar242
Copy link
Contributor Author

recheck

@mandar242 mandar242 changed the title manage_vpc_peering: fix integration tests manage_vpc_peering: fix integration tests, update role var names Jul 26, 2023
Copy link
Contributor

@abikouo abikouo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@abikouo abikouo merged commit 9c30127 into redhat-cop:main Jul 27, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants