Create a playbook to deploy a simple flask web app into high availability architecture #97
Conversation
GomathiselviS
changed the title
| @@ -85,7 +85,7 @@ To delete the webapp: | |||
| ### Common | |||
|
|
|||
| * **operation** (str): Operation for the webapp playbook to perform, either `create` or `delete`. Default: `create` | |||
| * **resource_prefix** (str): (Required) A prefix to prepend to the name of all AWS resources created for the webapp | |||
| * **resource_prefix** (str): A prefix to prepend to the name of all AWS resources created for the webapp. Default: `ansible-test` | |||
There was a problem hiding this comment.
Is this a breaking_change?
There was a problem hiding this comment.
This modification should have no impact on current users of this playbook. I don't consider it a breaking change. I believed that setting a default value, rather than making it a required parameter, was a more practical approach.
| @@ -157,6 +157,25 @@ To delete the webapp: | |||
| ``` | |||
| * **deploy_flask_app_force_init** (bool): Whether to drop existing tables and create new ones when deploying the webapp database. Default: `false` | |||
|
|
|||
| ### webapp deployment in HA architecture | |||
There was a problem hiding this comment.
In this deployment deploy_flask_app_workers_instance_type uses a t3.micro and cannot see where it is documented. It will be probably better to create a dedicated README for the high availability deployment especially if some default values from the webapp deployment are not retained. I personally find it clearer to to have separate READMEs, you can also reference the other rather than duplicating information.
There was a problem hiding this comment.
I have referenced the other variables used for this playbook here - https://github.com/redhat-cop/cloud.aws_ops/pull/97/files#diff-9ac3987075e323c6dbca1ada8d6a37a9768cbc9f22ae5168b3d84c49556422e1R164. I can add a link.
There was a problem hiding this comment.
Regarding the usage of t3.micro , based on this comment, I am retaining the default value - 't2.xlarge'. I will remove t3.micro from the playbooks and use it only for our testing.
…lity architecture
GomathiselviS
force-pushed
the
webapp_HA
branch
from
8a71c51
to
4082b9e
Compare
Reference jira ticket : https://issues.redhat.com/browse/ACA-1022