ACA-1839: Fixed undefined var issue for azure_manage_postgresql role …

…in create.yml
redhat-cop · Sep 12, 2024 · 363b268 · 363b268
1 parent a67fbb9
commit 363b268
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/changelogs/fragments/20241109-azure_manage_postgresql.yml b/changelogs/fragments/20241109-azure_manage_postgresql.yml
@@ -0,0 +1,2 @@
+bugfixes:
+  - Fixed the undefined variables issue in the create.yml and delete.yml of azure_manage_postgresql role.
diff --git a/roles/azure_manage_postgresql/tasks/create.yml b/roles/azure_manage_postgresql/tasks/create.yml
@@ -64,6 +64,7 @@
     value: "{{ item.value }}"
   with_items: "{{ azure_manage_postgresql_postgresql_settings }}"
   when:
+    - azure_manage_postgresql_postgresql_settings is defined
     - azure_manage_postgresql_postgresql_settings | length > 0
 
 - name: Update PostgreSQL Server Firewall rules
@@ -75,6 +76,7 @@
     end_ip_address: "{{ item.end_ip_address }}"
   with_items: "{{ azure_manage_postgresql_postgresql_firewall_rules }}"
   when:
+    - azure_manage_postgresql_postgresql_firewall_rules is defined
     - azure_manage_postgresql_postgresql_firewall_rules | length > 0
 
 - name: Create/Update PostgreSQL Database instances
@@ -87,4 +89,5 @@
     force_update: "{{ item.force | default(omit) }}"
   with_items: "{{ azure_manage_postgresql_postgresql_database_instances }}"
   when:
+    - azure_manage_postgresql_postgresql_database_instances is defined
     - azure_manage_postgresql_postgresql_database_instances | length > 0
diff --git a/roles/azure_manage_postgresql/tasks/delete.yml b/roles/azure_manage_postgresql/tasks/delete.yml
@@ -7,6 +7,9 @@
     value: "{{ item.value }}"
     state: absent
   with_items: "{{ azure_manage_postgresql_postgresql_settings }}"
+  when:
+    - azure_manage_postgresql_postgresql_settings is defined
+    - azure_manage_postgresql_postgresql_settings | length > 0
 
 - name: Delete PostgreSQL Server Firewall rules
   azure.azcollection.azure_rm_postgresqlfirewallrule:
@@ -15,6 +18,9 @@
     name: "{{ item.name }}"
     state: absent
   with_items: "{{ azure_manage_postgresql_postgresql_firewall_rules }}"
+  when:
+    - azure_manage_postgresql_postgresql_firewall_rules is defined
+    - azure_manage_postgresql_postgresql_firewall_rules | length > 0
 
 - name: Delete PostgreSQL Database instances
   azure.azcollection.azure_rm_postgresqldatabase:
@@ -24,6 +30,9 @@
     force_update: "{{ item.force | default(omit) }}"
     state: absent
   with_items: "{{ azure_manage_postgresql_postgresql_database_instances }}"
+  when:
+    - azure_manage_postgresql_postgresql_database_instances is defined
+    - azure_manage_postgresql_postgresql_database_instances | length > 0
 
 - name: Delete PostgreSQL Server if requested
   azure.azcollection.azure_rm_postgresqlserver:
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		bugfixes:
		- Fixed the undefined variables issue in the create.yml and delete.yml of azure_manage_postgresql role.