Skip to content

Commit

Permalink
ACA-1602: Removing SKU tier, capacity and size parameters from role a…
Browse files Browse the repository at this point in the history
…nd test

Signed-off-by: hyaish <[email protected]>
  • Loading branch information
Yaish25491 committed Jul 21, 2024
1 parent 31a8585 commit a3fea82
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 7 deletions.
4 changes: 4 additions & 0 deletions changelogs/fragments/20240721-azure_manage_postgresql.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
bugfix:
- Removing tier, capacity, and size from SKU parameters from README file, both from Role Variables and Example Playbook.
- Removing azure_manage_postgresql_postgresql_sku.tier from defalts.
- Removing _postgresql.servers[0].sku.tier from assert testing.
4 changes: 0 additions & 4 deletions roles/azure_manage_postgresql/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ Role Variables
* **azure_manage_postgresql_postgresql_name**: The name of the Server.
* **azure_manage_postgresql_postgresql_sku**: The SKU (pricing tier) of the server.
- **name**: The name of the SKU, typically, tier + family + cores, for example **B_Gen4_1**, **GP_Gen5_8**.
- **tier**: The tier of the particular SKU. Valid values are **Basic**, **Standard**.
- **capacity**: The scale up/out capacity, representing the server's compute units.
- **size**: The size code, to be interpreted by resource as appropriate.
* **azure_manage_postgresql_postgresql_storage_mb**: The maximum storage allowed for a server.
* **azure_manage_postgresql_postgresql_geo_redundant_backup**: Choose between locally redundant(default) or geo-redundant backup. This cannot be updated after first deployment. Default: **False**
* **azure_manage_postgresql_postgresql_backup_retention_days**: Backup retention period between 7 and 35 days. 7 days by default if not set
Expand Down Expand Up @@ -78,7 +75,6 @@ Example Playbook
azure_manage_postgresql_postgresql_storage_mb: 5120
azure_manage_postgresql_postgresql_sku:
name: B_Gen5_1
tier: Basic
azure_manage_postgresql_resource_group_tags:
tag0: "tag0"
tag1: "tag1"
Expand Down
2 changes: 1 addition & 1 deletion roles/azure_manage_postgresql/tasks/create.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
source_server_id: "{{ azure_manage_postgresql_postgresql_source_server_id | default(omit) }}"
restore_point_in_time: "{{ azure_manage_postgresql_manage_postgresql_postgresql_restore_point_in_time | default(omit) }}"
tags: "{{ azure_manage_postgresql_tags | default(omit) }}"

- name: Update PostgreSQL Server configuration settings
azure.azcollection.azure_rm_postgresqlconfiguration:
resource_group: "{{ azure_manage_postgresql_resource_group }}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@ azure_manage_postgresql_postgresql_name: "{{ resource_prefix }}-postgresql-serve
azure_manage_postgresql_postgresql_admin_username: "ansible"
azure_manage_postgresql_postgresql_sku:
name: "B_Gen5_1"
tier: "Basic"
azure_manage_postgresql_postgresql_storage_mb: 5120
azure_manage_postgresql_postgresql_backup_retention_days: 10
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
- _postgresql.servers[0].name == azure_manage_postgresql_postgresql_name
- _postgresql.servers[0].location == azure_manage_postgresql_region
- _postgresql.servers[0].sku.name == azure_manage_postgresql_postgresql_sku.name
- _postgresql.servers[0].sku.tier == azure_manage_postgresql_postgresql_sku.tier
- _postgresql.servers[0].storage_mb == azure_manage_postgresql_postgresql_storage_mb
- _postgresql.servers[0].admin_username == azure_manage_postgresql_postgresql_admin_username
- _postgresql.servers[0].version == azure_manage_postgresql_postgresql_version
Expand Down

0 comments on commit a3fea82

Please sign in to comment.