Enable Integration tests procedure and add CONTRIBUTING MD file #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @p3ck |
anna-savina
reviewed
Apr 9, 2024
anna-savina
reviewed
Apr 9, 2024
anna-savina
reviewed
Apr 9, 2024
nirarg
force-pushed
the
integration
branch
2 times, most recently
from
378a82b to
92268de
Compare
anna-savina
reviewed
Apr 10, 2024
CONTRIBUTING.md
Outdated
|
|
||
| > **_NOTE:_** Make sure to replace `<working directory>` with the actual path where you want to clone the repositories and set up your environment. | ||
|
|
||
| 1. **Clone This Repository**: |
There was a problem hiding this comment.
Suggested change
| 1. **Clone This Repository**: | |
| 1. **Clone Azure Roles Collection Repository**: |
There was a problem hiding this comment.
I changed the descriptions in the clone steps.
Please review
|
lgtm |
|
lgtm, all tests passed |
nirarg
force-pushed
the
integration
branch
2 times, most recently
from
d0918aa to
55b3794
Compare
p3ck
approved these changes
Apr 16, 2024
|
Looks like the changelog format isn't quite right..
|
@p3ck fixed this error, I think it ready for merge now |
These error were detected by the integration test: * "azure_manage_security_group_region" should be optional, as it not required when the \"Resource Group\" is already exists. * Fix "purge_rules" and "rules_to_remove" indentation in the arguments spec
p3ck
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.