Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Example Playbook in README file #76

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Fixed Example Playbook in README file #76

merged 1 commit into from
Jun 2, 2024

Conversation

anna-savina
Copy link
Collaborator

Fixed issues:

  • No 'vars' section, all variables listed at the same level with role and name
  • Playbooks organized by role, not by tasks. It makes it difficult to reuse given examples in real life.

@anna-savina anna-savina force-pushed the fix_example_playbook branch from 7706b46 to 38ef947 Compare May 30, 2024 10:05
@anna-savina anna-savina force-pushed the fix_example_playbook branch from 38ef947 to 38cebd0 Compare May 30, 2024 10:12
p3ck
p3ck approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@p3ck p3ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

nirarg
nirarg approved these changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@nirarg nirarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!!!

@nirarg nirarg merged commit f46ca6c into redhat-cop:main Jun 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabinovRedhat prabinovRedhat prabinovRedhat approved these changes

@nirarg nirarg nirarg approved these changes

@p3ck p3ck p3ck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anna-savina @p3ck @nirarg @prabinovRedhat